926594 - Some debug mochitests on B2G take a bit over 300s and time out

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Jonathan Griffin (:jgriffin)]

When run on debug emulators, a few mochitests run over 300s and time out, e.g.,

12:35:48     INFO -  37073 INFO TEST-PASS | /tests/layout/style/test/test_media_queries.html | cloning query '(grid: 1)' should not change serialization
12:35:48     INFO -  37074 INFO TEST-PASS | /tests/layout/style/test/test_media_queries.html | Media query '(grid: 1)' should NOT apply after cloning
12:35:59     INFO -  37075 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/style/test/test_media_queries.html | Test timed out.
12:35:59     INFO -  ++DOMWINDOW == 27 (0x447abd5c) [serial = 1715] [outer = 0x44005a5c]
12:35:59     INFO -  37076 INFO TEST-PASS | /tests/layout/style/test/test_media_queries.html | cloning query '(grid: 2)' should not change serialization
12:35:59     INFO -  37077 INFO TEST-PASS | /tests/layout/style/test/test_media_queries.html | Media query '(grid: 2)' should NOT apply after cloning
12:35:59     INFO -  ++DOMWINDOW == 28 (0x44002edc) [serial = 1716] [outer = 0x44005a5c]
12:35:59     INFO -  37078 INFO TEST-PASS | /tests/layout/style/test/test_media_queries.html | cloning query '(grid: -1)' should not change serialization
12:35:59     INFO -  37079 INFO TEST-PASS | /tests/layout/style/test/test_media_queries.html | Media query '(grid: -1)' should NOT apply after cloning
12:35:59     INFO -  ++DOMWINDOW == 29 (0x44006c7c) [serial = 1717] [outer = 0x44005a5c]
12:35:59     INFO -  37080 INFO TEST-END | /tests/layout/style/test/test_media_queries.html | finished in 313086ms

We should probably increase the timeout for debug mochitests to 420s or so.

Comment 1

[Jonathan Griffin (:jgriffin)]

Attachment: Increase timeout for debug mochitests on B2G,

try: https://tbpl.mozilla.org/?tree=Try&rev=d0ebe079482e

Comment 2

[Jonathan Griffin (:jgriffin)]

Attachment: Increase timeout for debug mochitests on B2G,

Comment 3

[Andrew Halberstadt [:ahal]]

Comment on attachment 819113 [details] [diff] [review]
Increase timeout for debug mochitests on B2G,

Review of attachment 819113 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/mochitest/runtestsb2g.py
@@ +120,5 @@
> +                if mozinfo.info['debug']:
> +                    options.timeout = 420
> +                else:
> +                    options.timeout = 330
> +            timeout = options.timeout + 30.0

I don't really understand why we add 30, but in any case I think the default for options.timeout should be 300 so that the +30 gives 330 total. Right now it'll get set to 360. Similarly I think for debug we can just make it 400 for a total of 430

Comment 4

[Jonathan Griffin (:jgriffin)]

(In reply to Andrew Halberstadt [:ahal] from comment #3)
> Comment on attachment 819113 [details] [diff] [review]
> Increase timeout for debug mochitests on B2G,
> 
> Review of attachment 819113 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: testing/mochitest/runtestsb2g.py
> @@ +120,5 @@
> > +                if mozinfo.info['debug']:
> > +                    options.timeout = 420
> > +                else:
> > +                    options.timeout = 330
> > +            timeout = options.timeout + 30.0
> 
> I don't really understand why we add 30, but in any case I think the default
> for options.timeout should be 300 so that the +30 gives 330 total. Right now
> it'll get set to 360. Similarly I think for debug we can just make it 400
> for a total of 430

Good catch.  We add 30 to give the JS harness a chance to timeout a test before the Python harness times it out, since the latter results in us aborting the test run.

Comment 5

[Jonathan Griffin (:jgriffin)]

Addressed review comments and pushed to inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/acc16ae0e638

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/acc16ae0e638