926598 - MediaPipeline.h(86) : warning C4355: 'this' : used in base member initializer list (also line 520)

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Description

[Daniel Holbert [:dholbert]]

Noticed at the end of this build log:
{
e:\builds\moz2_slave\m-in-w32-000000000000000000000\build\media\webrtc\signaling\src\mediapipeline\MediaPipeline.h(86) : warning C4355: 'this' : used in base member initializer list
e:\builds\moz2_slave\m-in-w32-000000000000000000000\build\media\webrtc\signaling\src\mediapipeline\MediaPipeline.h(520) : warning C4355: 'this' : used in base member initializer list
}
https://tbpl.mozilla.org/php/getParsedLog.php?id=29093837&tree=Mozilla-Inbound

Filing this bug on fixing those build warnings. The latter can be silenced with MOZ_THIS_IN_INITIALIZER_LIST(); the former requires a bit more delicate work.

(Note that these warnings are unrelated to the build failure in the log linked above; they're just contextual buildspew that happened to be highlighted due to being near the build failure.)

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: fix some this-in-initializer warnings and remove tabs in MediaPipeline

Comment 2

[Daniel Holbert [:dholbert]]

Comment on attachment 816764 [details] [diff] [review]
fix some this-in-initializer warnings and remove tabs in MediaPipeline

LGTM, fwiw.

One suggested comment-tweak:

>diff --git a/media/webrtc/signaling/src/mediapipeline/MediaPipeline.h b/media/webrtc/signaling/src/mediapipeline/MediaPipeline.h
[...]
>+      // PipelineTransport() will access this->sts_thread_; moved here for safety
>+      transport_ = new PipelineTransport(this);

maybe s/moved here/initialized here/ ?

("moved" makes sense in the context of the patch, but it makes less sense if you're just reading the code.)

Comment 3

[Eric Rescorla (:ekr)]

Comment on attachment 816764 [details] [diff] [review]
fix some this-in-initializer warnings and remove tabs in MediaPipeline

Review of attachment 816764 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6eec00ce4193

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6eec00ce4193