Closed Bug 926607 Opened 6 years ago Closed 6 years ago

./mach help on B2G: KeyError: u'disabled'

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla27

People

(Reporter: jgriffin, Assigned: ahal)

Details

Attachments

(2 files)

mach help fails on B2G due to this error:

KeyError: u'disabled'

  File "/home/jgriffin/armB2G/../mozilla-inbound/src/python/mach/mach/main.py", line 265, in run
    return self._run(argv)
  File "/home/jgriffin/armB2G/../mozilla-inbound/src/python/mach/mach/main.py", line 310, in _run
    args = parser.parse_args(argv)
  File "/usr/lib/python2.7/argparse.py", line 1688, in parse_args
    args, argv = self.parse_known_args(args, namespace)
  File "/usr/lib/python2.7/argparse.py", line 1720, in parse_known_args
    namespace, args = self._parse_known_args(args, namespace)
  File "/usr/lib/python2.7/argparse.py", line 1929, in _parse_known_args
    stop_index = consume_positionals(start_index)
  File "/usr/lib/python2.7/argparse.py", line 1885, in consume_positionals
    take_action(action, args)
  File "/usr/lib/python2.7/argparse.py", line 1794, in take_action
    action(self, namespace, argument_values, option_string)
  File "/home/jgriffin/armB2G/../mozilla-inbound/src/python/mach/mach/dispatcher.py", line 96, in __call__
    self._handle_main_help(parser)
  File "/home/jgriffin/armB2G/../mozilla-inbound/src/python/mach/mach/dispatcher.py", line 188, in _handle_main_help
    title, description, _priority = r.categories['disabled']

This occurs because there is no 'disabled' category in B2G's version of mach_bootstrap:  https://github.com/mozilla-b2g/B2G/blob/master/tools/mach_b2g_bootstrap.py

We could easily add it there; is that the preferred fix?
We could do that, though I think the fix is to add a check to see if it exists first. My mistake, patch coming shortly.
This should fix the bug, but we'll probably want to add the disabled category to the b2g bootstrap anyway. I'll get a patch up for that in a bit.
Attachment #817283 - Flags: review?(jgriffin)
Comment on attachment 817283 [details] [diff] [review]
Patch 1.0 - check for disabled category

Review of attachment 817283 [details] [diff] [review]:
-----------------------------------------------------------------

thx!
Attachment #817283 - Flags: review?(jgriffin) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/875ab904cc99

Leaving open to track the change to the b2g bootstrap script.
Assignee: nobody → ahalberstadt
Status: NEW → ASSIGNED
Whiteboard: [leave-open]
Comment on attachment 817969 [details] [review]
Patch 1.0  (B2G) - add disabled category to mach bootstrap

Thanks!
Attachment #817969 - Flags: review?(jgriffin) → review+
Could you merge the pull request please?
https://github.com/mozilla-b2g/B2G/pull/287
https://github.com/mozilla-b2g/B2G/commit/9ebfaca574dc70893494ef445880ff897a7cb03b
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [leave-open]
Target Milestone: --- → mozilla27
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.