926611 - Localization Metrics Dashboard doesn't adjust the axis

Status: RESOLVED FIXED

(support.mozilla.org :: Localization, task, P3)

Description

[Ibai Garcia [:ibai]]

Steps to reproduce:

1) Go to https://support.mozilla.org/en-US/kb/dashboard/metrics/aggregated
2) Uncheck every locale but "ru"
3) See the second graph.
4) The curve treats the Y axis dynamically, so it takes all the space of the vertical spaces, but the axis values don't change. Making it look like Russian is 100% localized where the reality is that is 28% localized.

Expected behaviour:

1) Go to https://support.mozilla.org/en-US/kb/dashboard/metrics/aggregated
2) Uncheck every locale but "ru"
3) See the second graph.
4) The Y axis max. value should represent the max. value of the curves that are being graphed.

Comment 1

[Ricky Rosario [:rrosario, :r1cky]]

I had this on my list of bugs to file. Thanks for filing!

Comment 2

[Michael Cooper [:mythmon]]

I think this is just Ricky's checkboxes not tying into enough of the rickshaw helper stuff. It should be a simple fix, about 1pt.

Comment 3

[Ricky Rosario [:rrosario, :r1cky]]

I'll give it a shot!

Comment 4

[Ricky Rosario [:rrosario, :r1cky]]

In a pull request:
https://github.com/mozilla/kitsune/pull/1681

Comment 5

[Ricky Rosario [:rrosario, :r1cky]]

Landed on master:
https://github.com/mozilla/kitsune/commit/5466e67806ff74fe41ef1b9cb929c2427b27fc97

Comment 6

[Ricky Rosario [:rrosario, :r1cky]]

Deployed to prod.