926636 - No longer preventing apps from being restored on 10.7/10.8 startup

Status: RESOLVED FIXED

(Infrastructure & Operations :: RelOps: Puppet, task)

Description

[Phil Ringnalda (:philor)]

<philor>: did we do something to overwrite what was supposed to keep iCal from being perpetually open on 10.7 test slaves?
<philor>: "what" being https://bug843545.bugzilla.mozilla.org/attachment.cgi?id=717277
<Callek|buildduty>: philor: hrm yes yes we did
<Callek|buildduty>: philor: can you file a bug on that in Infra&Ops::Relops: Puppet ?
<Callek|buildduty>: LoginwindowLaunchesRelaunchApps is the flag we want

Comment 1

[Phil Ringnalda (:philor)]

Should I just assume this isn't going to be fixed, and disable the test that opens iCal, and then, um, get every 10.7 test slave reimaged I guess?

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

We should do this.  Callek, can you either write the patch or give me the details I'd need to do so?

Comment 3

[Justin Wood (:Callek)]

Attachment: [puppet] disable it

Solution is based on what we did in old-puppet and http://apple.stackexchange.com/questions/24783/uncheck-reopen-windows-when-logging-back-in-by-default

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8356190 [details] [diff] [review]
[puppet] disable it

Review of attachment 8356190 [details] [diff] [review]:
-----------------------------------------------------------------

::: modules/disableservices/manifests/common.pp
@@ +110,5 @@
> +	        'disable-relaunch-apps':
> +		    domain => "/Library/Preferences/com.apple.loginwindow",
> +                    key => "LoginwindowLaunchesRelaunchApps",
> +                    value => "0",
> +                    require => Class['users::builder'];

This require isn't, um, required.  I suspect the one above is not either.

Comment 5

[Justin Wood (:Callek)]

I left the requires in (for now) -- I felt they didn't hurt at least.

http://hg.mozilla.org/build/puppet/rev/18afa2bef4a2
+ merge (http://hg.mozilla.org/build/puppet/rev/83ca0e396389)