Closed
Bug 926823
Opened 11 years ago
Closed 11 years ago
do not flip sign of |time.timezone|
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: skao, Assigned: skao)
References
Details
(Whiteboard: [mentor=gene])
Attachments
(1 file)
+++ This bug was initially created as a clone of Bug #926777 +++ When bug 926777 lands, the value of time.timezone will given in general format so no need to flip the sign in gaia. Also I found when the selected timezone is equal to the timezone we get from NITZ, the timezone string (UTC+8:00) won't show when auto update is on, will fix it in this bug too.
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → skao
|
|
Assignee | |
Comment 1•11 years ago
|
||
|
||
Comment 2•11 years ago
|
||
Rudy is the right person to take this review. :)
|
|
Assignee | |
Updated•11 years ago
|
Attachment #817048 -
Flags: review?(rlu)
|
||
Updated•11 years ago
|
Attachment mime type: text/plain → text/x-github-pull-request
|
|
Assignee | |
Comment 3•11 years ago
|
||
Hi Rudy, Since bug 926777 is ready to land, we'll see wrong timezone strings without this patch after that so it's better to land these two patches toghether. Could you have a look at the pull request? Thanks!
|
||
Comment 4•11 years ago
|
||
Comment on attachment 817048 [details] [review] Link to pull request r=me, thanks for working on this.
Attachment #817048 -
Flags: review?(rlu) → review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
|
||
Comment 5•11 years ago
|
||
Merged to Gaia master, https://github.com/mozilla-b2g/gaia/commit/71e415a79b8022e3132ff80068dee4ba18ff1157
You need to log in
before you can comment on or make changes to this bug.
Description
•