Open Bug 926859 Opened 11 years ago Updated 10 months ago

Calling PopupNotification.remove() from notification constructor leaves floating popup

Categories

(Toolkit :: PopupNotifications and Notification Bars, defect)

defect

Tracking

()

People

(Reporter: gfritzsche, Unassigned)

References

(Depends on 1 open bug)

Details

Attachments

(1 file)

Calling |PopupNotification.remove(this.notification)| from a notification constructor (e.g. [1]), removes the notification icon/anchor in the location bar but leaves the popup floating around.

[1] http://hg.mozilla.org/mozilla-central/annotate/0e26e6f12ad9/browser/base/content/urlbarBindings.xml#l1569
Blocks: 922349
No longer blocks: 841587
The same problem occurs when trying to remove() the notification from the event callback, which is fired via:

PopupNotifications_fireCallback: http://hg.mozilla.org/mozilla-central/annotate/0e26e6f12ad9/toolkit/modules/PopupNotifications.jsm#l750
PopupNotifications_showPanel: http://hg.mozilla.org/mozilla-central/annotate/0e26e6f12ad9/toolkit/modules/PopupNotifications.jsm#l555
This is only an issue when trying to remove() the notification from the sync "showing" callback or it's constructor. When delaying the removal using e.g. setTimeout(f,0) it works fine.

Given that, bug 927177 should resolve this if the callbacks can be made async.
No longer blocks: 922349
Depends on: 927177
Bulk move to Toolkit::Notifications and Alerts

Filter on notifications-and-alerts-component.
Component: XUL Widgets → Notifications and Alerts
Severity: normal → S3
Component: Notifications and Alerts → PopupNotifications and Notification Bars
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: