Closed Bug 926902 Opened 6 years ago Closed 6 years ago

Incorrect error locations for errors from scripts importScripts'ed by the frameworker

Categories

(Firefox Graveyard :: SocialAPI, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 27

People

(Reporter: florian, Assigned: florian)

References

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
Example of error I got:
TypeError: callback is not a function @ resource://gre/modules/FrameWorker.jsm:252

The line number is actually the real line of the error + the line of the evalInSandbox call (as explained in bug 307984).
Attachment #817148 - Flags: review?(mhammond)
Comment on attachment 817148 [details] [diff] [review]
Patch

Review of attachment 817148 [details] [diff] [review]:
-----------------------------------------------------------------

nice!
Attachment #817148 - Flags: review?(mhammond) → review+
Pushed to try to ensure the test works on all platforms: https://tbpl.mozilla.org/?tree=Try&rev=783e38a12527
https://hg.mozilla.org/mozilla-central/rev/8c8de10998cb
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 27
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.