Drop support for GNU make < 3.81

RESOLVED FIXED in mozilla27

Status

defect
RESOLVED FIXED
6 years ago
a year ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

Trunk
mozilla27
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Assignee

Description

6 years ago
- Windows builds with GNU make don't work at all, and even with bug 925605 reintroducing it, it's not going to work with versions < 4.0
- The last version of OSX that comes with GNU make 3.80 is 10.4.10. Apple started shipping 3.81 with 10.4.11 and 10.5.
- Centos 6, as far as I can tell, comes with 3.81.
- Debian has 3.81 since at least squeeze which is now oldstable.
- Ubuntu has 3.81 since at least lucid (10.04).

Dropping support for 3.80 would allow us to get rid of things like core_abspath, which is mostly there because 3.80 doesn't have $(abspath).
Assignee

Comment 1

6 years ago
Attachment #817797 - Flags: review?(gps)
Assignee

Updated

6 years ago
Assignee: nobody → mh+mozilla
Status: NEW → ASSIGNED
Assignee

Updated

6 years ago
Blocks: 924992
Attachment #817797 - Flags: review?(gps) → review+
Comment on attachment 817798 [details] [diff] [review]
Kill core_abspath, core_realpath and core_winabspath

Review of attachment 817798 [details] [diff] [review]:
-----------------------------------------------------------------

Good riddance.

::: toolkit/locales/l10n.mk
@@ -33,5 @@
>  # build non-default locales to non-default dist/ locations. Be aware!
>  
>  AB = $(firstword $(subst -, ,$(AB_CD)))
>  
> -core_abspath = $(if $(findstring :,$(1)),$(1),$(if $(filter /%,$(1)),$(1),$(CURDIR)/$(1)))

How much do you want to bet that the l10n repack machines don't have 3.81 installed? :)
Attachment #817798 - Flags: review?(gps) → review+
https://hg.mozilla.org/mozilla-central/rev/cdf1843edbcc
https://hg.mozilla.org/mozilla-central/rev/7f1302ea2a9b
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27

Updated

6 years ago
Blocks: 928966
I think this change broke release builds. I was doing a staging beta release with the current aurora code and hit the following error on OSX (notice the target zip file name): 

cp -RL /builds/slave/rel-m-beta-osx64_bld-000000000/build/testing/profiles/prefs_general.js ./dist/test-package-stage/steeplechase
/builds/slave/rel-m-beta-osx64_bld-000000000/build/obj-firefox/i386/config/nsinstall -D ./dist/mac/en-US/
find ./dist/test-package-stage -name "*.pyc" -exec rm {} \;
cd ./dist/test-package-stage && \
	  zip -rq9D "/builds/slave/rel-m-beta-osx64_bld-000000000/build/obj-firefox/i386/dist/mac/en-US/Firefox /builds/slave/rel-m-beta-osx64_bld-000000000/build/obj-firefox/i386/27.0b1.tests.zip" \
	  * -x \*/.mkdir.done
zip I/O error: No such file or directory
zip error: Could not create output file (/builds/slave/rel-m-beta-osx64_bld-000000000/build/obj-firefox/i386/dist/mac/en-US/Firefox /builds/slave/rel-m-beta-osx64_bld-000000000/build/obj-firefox/i386/27.0b1.tests.zip)
make[3]: *** [package-tests] Error 15
make[2]: *** [postflight_all] Error 2
make[1]: *** [realbuild] Error 2
make: *** [build] Error 2
Blocks: 943057
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Updated

6 years ago
Blocks: 944770
I'm going to open a follow up bug instead.
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago6 years ago
Resolution: --- → FIXED

Updated

6 years ago
Blocks: 944813

Updated

6 years ago
No longer blocks: 944770

Updated

6 years ago
No longer blocks: 943057

Updated

a year ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.