926936 - Can't launch an app when running Gaia inside Firefox with the desktop helpers

Status: RESOLVED FIXED

(Core Graveyard :: DOM: Apps, defect)

Description

[Julien Wajsberg [:julienw] (PTO -> Mar 16)]

STR:
* have a recent master
* have a desktop profile:
  rm -rf profile-browser && PROFILE_FOLDER=profile-browser DEBUG=1 make profile-browser
* run Firefox nightly with this profile
* try to launch an app

Expected:
* the apps can be launched

Actual:
* nothing happens and there is an error in the console:

System JS : ERROR resource://gre/modules/WebappOSUtils.jsm:224
                     TypeError: aPossiblyBadFilenameString is undefined

Note: on a less recent master, I had the same error for only some apps (tried "dialer" and "contacts") whereas some others worked (tried "messages" and "browser").

Ccing a bunch of people since this could come from either homescreen, Webapps, or the desktop helper.

Comment 1

[Kevin Grandon :kgrandon]

Most likely need to update some extension code due to bug 924032, I'll take it.

Comment 2

[Kevin Grandon :kgrandon]

Attachment: Github pull request pointer

Comment 3

[[:fabrice] Fabrice Desré]

Comment on attachment 817206 [details]
Github pull request pointer

We also changed 'open-app' and 'close-app'. You want to update those if they are in you shell.js

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 817206 [details]
Github pull request pointer

Hi Fabrice,

We should be ok here. We currently have webapps-launch and open-app - and these have been changed to fire the custom event instead of mozChromeEvent. We're currently not handling close-app at all, but perhaps that could be another bug.

Comment 5

[Kevin Grandon :kgrandon]

Thanks for the review! If anyone is having this problem, you will need to rebuild your profile after grabbing the latest master.

Landed: https://github.com/mozilla-b2g/gaia/commit/130183cc45b439fde9c5c60c22c077aa5ab8a4e2