split robocop (rc) into 4 chunks

RESOLVED FIXED

Status

Release Engineering
General
RESOLVED FIXED
5 years ago
2 months ago

People

(Reporter: wesj, Assigned: kmoir)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Reporter)

Description

5 years ago
Trying to land a bunch of tests in bug 757481, I keep getting blues [1]. Until 883539 is fixed, I'd like to add an rc4 so that I can land.

[1] https://tbpl.mozilla.org/?tree=Try&rev=7926ed2a24aa
(Assignee)

Updated

5 years ago
Assignee: nobody → kmoir
Of course, this is only needed for Android 4.0 / panda.
(Assignee)

Comment 3

5 years ago
Created attachment 817578 [details] [diff] [review]
bug926991bbconfigs.patch
(Assignee)

Updated

5 years ago
Attachment #817576 - Flags: review?(jlund)
(Assignee)

Updated

5 years ago
Attachment #817578 - Flags: review?(jlund)

Comment 4

5 years ago
Comment on attachment 817576 [details] [diff] [review]
bug926991mh.patch

Review of attachment 817576 [details] [diff] [review]:
-----------------------------------------------------------------

neat. I didn't realize how similar this was to desktop unittests in mozharness!
Attachment #817576 - Flags: review?(jlund) → review+

Comment 5

5 years ago
Comment on attachment 817578 [details] [diff] [review]
bug926991bbconfigs.patch

Review of attachment 817578 [details] [diff] [review]:
-----------------------------------------------------------------

looks good to me!
Attachment #817578 - Flags: review?(jlund) → review+

Comment 6

5 years ago
Comment on attachment 817576 [details] [diff] [review]
bug926991mh.patch

Review of attachment 817576 [details] [diff] [review]:
-----------------------------------------------------------------

::: configs/android/android_panda_releng.py
@@ +118,5 @@
>          "jsreftest-2": ["--total-chunks=3", "--this-chunk=2"],
>          "jsreftest-3": ["--total-chunks=3", "--this-chunk=3"],
>      },
>      "all_robocop_suites": {
>          #plain is split

I think this comment can come out too? Legacy copy/paste from somewhere else? (mochitest-plain perhaps?)
(Assignee)

Comment 7

5 years ago
Comment on attachment 817576 [details] [diff] [review]
bug926991mh.patch

removed comment too
Attachment #817576 - Flags: checked-in+
(Assignee)

Updated

5 years ago
Attachment #817578 - Flags: checked-in+
(Assignee)

Comment 8

5 years ago
Created attachment 817960 [details] [diff] [review]
bug926991try.patch

patch to update trychooser
Attachment #817960 - Flags: review?(jlund)

Comment 9

5 years ago
Comment on attachment 817960 [details] [diff] [review]
bug926991try.patch

Review of attachment 817960 [details] [diff] [review]:
-----------------------------------------------------------------

::: trychooser/index.html
@@ +242,5 @@
>              <li><label><input type="checkbox" value="mochitest-gl">mochitest-gl</label></li>
>              <li><label><input type="checkbox" value="robocop-1">robocop-1</label></li>
>              <li><label><input type="checkbox" value="robocop-2">robocop-2</label></li>
>              <li><label><input type="checkbox" value="robocop-3">robocop-3 <span class="info">(not x86)</span></label></li>
> +             <li><label><input type="checkbox" value="robocop-4">robocop-4 <span class="info">(not x86)</span></label></li>

looks good to me. how come we specify not x86 for only chunks 3 and now 4? I'm having trouble seeing where we use robocop-{1-4} differently by platform bits?
Attachment #817960 - Flags: review?(jlund) → review+
(Assignee)

Updated

5 years ago
Attachment #817960 - Flags: checked-in+
(Assignee)

Updated

5 years ago
Depends on: 927523
(Assignee)

Comment 10

5 years ago
verified on tbpl
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Component: General Automation → General
Product: Release Engineering → Release Engineering
You need to log in before you can comment on or make changes to this bug.