927049 - package source in breakpad.tar.gz

Status: RESOLVED FIXED

(Socorro :: Infra, task)

Description

[Robert Helmer [:rhelmer]]

We have a tool in the Socorro repo (stackwalker) which depends on the Breakpad source.

We should either package up the whole source (from before a configure), or just the libraries it needs. If it's not too huge it's probably simpler to do the former.

Comment 1

[Robert Helmer [:rhelmer]]

The "./src" dir is currently ~12MB compressed. The breakpad.tar.gz that we produce now is ~8MB.

I don't think this will break the bank.

Comment 2

[(not currently active) Ted Mielczarek]

If you just package the source then you'll have to rebuild the whole thing to build the stackwalker binary. You could package the source + the two libraries the stackwalker needs:
http://hg.mozilla.org/users/tmielczarek_mozilla.com/minidump-stackwalk/file/b99899ee43c7/Makefile#l3

and then build the stackwalker against that.

Comment 3

[Robert Helmer [:rhelmer]]

For posterity, the way to put the build back the way it was (with or without the source and stackwalker bits) is to have this in the Jenkins config (from my notes):

wget 'https://raw.github.com/mozilla/socorro/master/scripts/build-breakpad.sh'
bash build-breakpad.sh

Also, Jenkins should poll http://google-breakpad.googlecode.com/svn/trunk google-breakpad for changes instead of the Socorro github repo.

We could back ba51b1bd8d4598e9d9d347558502b73bc122b262 and 3fe2c316aaaba2245b94d66d029d330edb7373a1 and 96e28fb99740a711c373b3e6aeee7f9a8a39eb31 out, or leave them in place and also take the PR I am working on - minidump_stackwalk is produced in any case.

However we are using a new compiler, so backing it all out might be the safest course if we're not going to ship stackwalker tomorrow... we can re-land everything in one commit so it'll be easier to deal with too.

Comment 4

[Robert Helmer [:rhelmer]]

r? https://github.com/mozilla/socorro/pull/1589

Note that this also needs the changes in comment 3

Comment 5

[Robert Helmer [:rhelmer]]

I put devtoolset-1.1 on the PATH on Jenkins, here's the full new Jenkins config for posterity:

export MAVEN_HOME=/usr/local/maven
export JAVA_HOME=/usr/lib/jvm/java-1.6.0-sun-1.6.0.22.x86_64
export PATH=$MAVEN_HOME/bin:$JAVA_HOME/bin:$PATH
export PATH=/opt/centos/devtoolset-1.1/root/usr/bin:$PATH
./scripts/build.sh

Comment 6

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/275c4aa741cb70f005597f4cd25ae0ec0b53cad8
fixes bug 927049 - package source and libs needed for JSON stackwalker

https://github.com/mozilla/socorro/commit/f64eee7262a003af1331a4c3a201b72f3619a066
Merge pull request #1597 from rhelmer/bug927049-package-breakad-src

fixes bug 927049 - package source and libs needed for JSON stackwalker

Comment 7

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/b7f8409eb0151c92ecb99c777c24a30880d857e9
bug 927049 - look in stackwalk dir for breakpad libs and source

https://github.com/mozilla/socorro/commit/257df08945ed9e5236c54e8bc2a1f7e9a771492b
Merge pull request #1598 from rhelmer/bug927049-package-breakad-src-followup

bug 927049 - look in stackwalk dir for breakpad libs and source

Comment 8

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/03ffe925b1a864cb112c87ec6c2160d7b511e7ea
bug 927049 - package up libdisasm.a for stackwalker

https://github.com/mozilla/socorro/commit/493df0c449bad2c3e4016a9de2ecb63a169c34e6
Merge pull request #1599 from rhelmer/bug927049-package-breakad-src-followup

bug 927049 - package up libdisasm.a for stackwalker

Comment 9

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/d90711202cf77a9b587686de6c814f4de8a4f554
bug 927049 -  point to packages srcdir for stackwalker

https://github.com/mozilla/socorro/commit/18aab4de7c522834823d85e5fd71dff7863852a2
Merge pull request #1600 from rhelmer/bug927049-package-breakad-src-followup

bug 927049 -  point to packages srcdir for stackwalker