927096 - Available add-on update not being installed

Status: RESOLVED INVALID

(Toolkit :: Add-ons Manager, defect)

Description

[Jorge Villalobos [:jorgev] (he/him)]

Steps to reproduce:
1) Go to https://addons.mozilla.org/addon/one-click-proxy/versions/?page=1#version-0.307 and install version 0.307.
2) Open the Add-ons Manager and do a check for updates, either global or for the individual add-on.

Observed:
No updates found.

Expected:
Update found to version 0.56, and then installed.

I looked at the request and response, and they appear to be normal: https://versioncheck.addons.mozilla.org/update/VersionCheck.php?reqVersion=2&id=jid0-zXo3XFGyiDalgkeEO4UYJTUwo2I@jetpack&version=0.307&maxAppVersion=22.*&status=userEnabled&appID={ec8030f7-c20a-464f-9b0e-13a3a9e97384}&appVersion=25.0&appOS=Darwin&appABI=x86_64-gcc3&locale=en-US&currentAppVersion=25.0&updateType=97&compatMode=normal

The log shows that the new version was at least identified:
[14:12:00.308] LOG addons.updates: Found an update entry for jid0-zXo3XFGyiDalgkeEO4UYJTUwo2I@jetpack version 0.56

However, the update doesn't install and there's no indication of an error.

Comment 1

[Dave Townsend [:mossop]]

In toolkit version format 0.307 > 0.56, so as far as the add-ons manager is concerned the only version returned in the update.rdf is older than the currently installed version so it doesn't update.

Comment 2

[Dave Garrett]

Here's the doc, in case you don't understand the issue here:
https://developer.mozilla.org/en-US/docs/Toolkit_version_format

Versions numbers are not decimals, but rather a series of integers separated by dots. Version 0.307 is major version zero & minor version 307, and version 0.56 is major version zero & minor version 56. This allows for versions in the form of "1.2.3" as well as to allow a version "1.10" to follow a version "1.9".

Somewhere in the distant past someone should've probably used dashes instead of dots here, but they didn't. Pretty much all software versioning uses dots in a format like this. It's on the list of nitpicks to fix with a time machine, right after reversing the order in domain naming to match paths and reversing the polarity of the definition of electrical current to match electron charge. (and yes, I added this last bit just so I could use the phrase "reverse the polarity" legitimately :) )

Comment 3

[Jorge Villalobos [:jorgev] (he/him)]

No, I know about this but always overlook it. This is probably the third or fourth time I file this same bug :|

Comment 4

[Tony Mechelynck [:tonymec]]

(In reply to Jorge Villalobos [:jorgev] from comment #3)
> No, I know about this but always overlook it. This is probably the third or
> fourth time I file this same bug :|

https://developer.mozilla.org/en-US/docs/Toolkit_version_format deserves attentive reading (and, I suppose, even rereading from time to time). Everytime I read it, I learn something more (not something new, since it was already there the previous time I read it, but something I had read and forgotten).