927104 - "tools reload" leaves remote connections running

Status: NEW

(DevTools :: Framework, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

We should close remote debugger connections as part of "tools reload" so that the remote side does not remain open.  For example:

1. Enable devtools.debugger.log in desktop Firefox
2. Use the App Manager to connect to a device
3. tools reload
4. Refresh the App Manager and reconnect to device
5. Start an app
6. You will see multiple "appOpen" messages, one for each connection

Comment 1

[Paul Rouget [:paul]]

Is it because we use debugger.closeListener(true) instead of debugger.destroy() ?

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Paul Rouget [:paul] from comment #1)
> Is it because we use debugger.closeListener(true) instead of
> debugger.destroy() ?

Well, actually neither of those methods are called directly...  "tools reload" just calls reload() on the loader instance, which tells the SDK loader to "unload":

https://mxr.mozilla.org/mozilla-central/source/toolkit/devtools/Loader.jsm#319

Maybe we need to ensure that things like debugger.destroy() are called before this "unload" happens...?  It's possible other clean up activities are being missed in a similar way.