Closed
Bug 927119
Opened 11 years ago
Closed 11 years ago
mozrunner should require mozcrash 0.9
Categories
(Testing :: Mozbase, defect)
Testing
Mozbase
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: emorley)
References
Details
Attachments
(1 file)
735 bytes,
patch
|
k0scist
:
review+
|
Details | Diff | Splinter Review |
Not sure if this really makes a difference (losing track of where we use mozrunner vs ?) but guess it doesn't hurt to bump this requirement as well.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #817437 -
Flags: review?(jhammel)
Comment 2•11 years ago
|
||
fine by me; though, to be fair, 1. not sure what exactly it fixes? 2. i'd argue that normally the time to do this is with a mozrunner version bump (weak opinion) Feel free to checkin, if desired
Updated•11 years ago
|
Attachment #817437 -
Flags: review?(jhammel) → review+
Assignee | ||
Comment 3•11 years ago
|
||
(In reply to Jeff Hammel [:jhammel] from comment #2) > 1. not sure what exactly it fixes? I don't know what uses mozrunner - I was concerned that something that uses it may end up relying on newly added functionality, so would rather bump the version requirement just in case. > 2. i'd argue that normally the time to do this is with a mozrunner version > bump (weak opinion) I wasn't going to re-mirror mozrunner, just check this in and leave for the next normal version bump.
Assignee | ||
Comment 4•11 years ago
|
||
Thank you :-) https://github.com/mozilla/mozbase/commit/61861b5c1606458ee5ccf75ee6e7b46f7464488e
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•