927120 - [api] syntax error hitting signatureURLs endpoint

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[Lonnen :lonnen]

https://errormill.mozilla.org/webtools/socorro-stage/group/120926/

from

 GET https://crash-stats.allizom.org/api/SignatureURLs/ 

 end_date   2013-10-10
 products   Firefox
 signature  nsBinaryOutputStream::WriteWStringZ(wchar_t const*)
 start_date 2013-10-08
 versions   27.0a1

also happens on prod:
https://crash-stats.allizom.org/api/SignatureURLs/?end_date=2013-10-10&products=Firefox&signature=nsBinaryOutputStream%3A%3AWriteWStringZ(wchar_t+const*)&start_date=2013-10-08&versions=27.0a1&pretty=print

Comment 1

[Selena Deckelmann :selenamarie :selena]

So, the API specifies that versions should be Product:Version i.e. Firefox:27.0a1

I can make the API return a more informative error message.. might need to fix whatever is calling that API as well.

Comment 2

[Lonnen :lonnen]

Ah. The API is inconsistent, then. In other places 27.0a1 is the format.

Comment 3

[Lonnen :lonnen]

https://github.com/mozilla/socorro/commit/32a461830c587adc8204c3a758a25f2e4f2fd63e

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

https://crash-stats.allizom.org/api/SignatureURLs/?end_date=2013-10-10&products=Firefox&signature=nsBinaryOutputStream%3A%3AWriteWStringZ%28wchar_t+const*%29&start_date=2013-10-08&versions=27.0a1&pretty=print throws a 400 BAD REQUEST.

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

I also verified the exception from comment 0 is no longer thrown (checked Errormill).

Verified FIXED on staging.