927128 - Keep GeckoView limited to Nightly only

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: GRE Core, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

We don't want GeckoView to move out of Nightly until we get the APIs a bit more mature

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: nightly-only v0.1

Mike - I think this should be enough to stop GeckoView from getting built anywhere but Nightly

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 8343546 [details] [diff] [review]
nightly-only v0.1

Review of attachment 8343546 [details] [diff] [review]:
-----------------------------------------------------------------

That'd prevent people from building a geckoview on non nightly branches if they want to. I don't know if it's a problem or not. If it is, it would be better to to that at configure.in level, resetting MOZ_DISABLE_GECKOVIEW when it's not already set (as in, export MOZ_DISABLE_GECKOVIEW=). That can be checked with:
  test "${MOZ_DISABLE_GECKOVIEW-unset}" = unset.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/integration/fx-team/rev/e7a6c931bcf5

But I do want to make a nicer approach, like the one in comment 2. I need this on Fx27 so I'll land this one for now.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8343546 [details] [diff] [review]
nightly-only v0.1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): GeckoView
User impact if declined: GeckoView widget is not ready for release, so we want to limit it to Nightly for now
Testing completed (on m-c, etc.): just landed
Risk to taking this patch (and alternatives if risky): simple makefile flag
String or IDL/UUID changes made by this patch: none

Comment 5

[bhavana bajaj [:bajaj]]

Comment on attachment 8343546 [details] [diff] [review]
nightly-only v0.1

PLease set the status-firefox27 -> disabled , once landed.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2c001ca401cc

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e7a6c931bcf5

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Backed out for bustage.
https://hg.mozilla.org/releases/mozilla-aurora/rev/dcf668ab8d94

https://tbpl.mozilla.org/php/getParsedLog.php?id=31585052&tree=Mozilla-Aurora

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: nightly-only-fix v0.1

I forgot to add the stub for INNER_MAKE_GECKOVIEW_LIBRARY. Without it, we break here:
http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/installer/packager.mk#462

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Backed out from Aurora due to the same bustage that hit when this was uplifted during the last cycle. We can land this on Aurora/Beta once the bustage fix gets reviewed.

https://hg.mozilla.org/releases/mozilla-aurora/rev/ecb386453084

Comment 11

[Mark Finkle (:mfinkle) (use needinfo?)]

Part 2
https://hg.mozilla.org/integration/fx-team/rev/bc93b00a405b

Comment 12

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8343546 [details] [diff] [review]
nightly-only v0.1

Batch request for both patches

[Approval Request Comment]
Bug caused by (feature/regressing bug #): GeckoView libraries
User impact if declined: Shipping alpha-ready GeckoView. We do not want the GeckoView libraries to move past Nightly yet.
Testing completed (on m-c, etc.): bustage fix now landed
Risk to taking this patch (and alternatives if risky): Should not affect Fennec/Firefox, but can break the build. The bustage fix corrects that.
String or IDL/UUID changes made by this patch: None

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/bc93b00a405b

Comment 14

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/6af6c1e0d964
https://hg.mozilla.org/releases/mozilla-aurora/rev/c7dace6817c0

https://hg.mozilla.org/releases/mozilla-beta/rev/556e787d9c7b
https://hg.mozilla.org/releases/mozilla-beta/rev/37e19e8605db