Closed Bug 927131 Opened 9 years ago Closed 9 years ago

Add an automated test to verify that you can import contacts from Gmail

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(b2g-v1.2 fixed)

RESOLVED FIXED
Tracking Status
b2g-v1.2 --- fixed

People

(Reporter: jsmith, Assigned: viorela)

Details

Attachments

(2 files, 2 obsolete files)

A big hotspot for regressions in the 1.2 timeframe was around importing of contacts from Gmail. We should get a basic UI test around importing from an existing gmail account with contacts included.
This is very similar to bug 927126.

Let's seed the gmail account in the testvars file with one or two contacts.


Test case as follows:
1. Start b2g
2. Tap 'Settings'
3. Tap 'Import Contacts'
4. Tap 'Gmail'
5. Sign in to Gmail
6. After import process, verify list of contacts is shown.
7. Select the contact and tap 'Import'
8. Verify that the imported contact(s) are listed on the Contacts app main screen.
I'll try this one. thanks!
I've set you assigned Viorela!
Assignee: nobody → viorelaioia
Attached file added test and encountered an issue (obsolete) —
pointer to pull request https://github.com/mozilla-b2g/gaia/pull/12976
Attachment #819715 - Flags: review?(zcampbell)
Attachment #819715 - Flags: review?(alin.trif)
Attachment #819715 - Flags: review-
Comment on attachment 819715 [details] [review]
added test and encountered an issue

r-
Nice pull, just a little few improvemnts and we are almost there. 
my comments are in the pr
Attachment #819715 - Flags: review?(trifandreialin) → review-
Comment on attachment 819715 [details] [review]
added test and encountered an issue

Comments in PR, just some small tweaks.

After you've pushed the fixes can you set us all to "r? " again and we'll know to review again :)
Attachment #819715 - Flags: review?(zcampbell) → review-
Attached file updated the pull request (obsolete) —
Attachment #824030 - Flags: review?(zcampbell)
Attachment #824030 - Flags: review?(trifandreialin)
Attachment #824030 - Flags: review?(moz.teodosia)
Attachment #824030 - Flags: review?(andrei.hutusoru)
Attachment #824030 - Flags: review?(moz.teodosia) → review-
Comment on attachment 824030 [details] [review]
updated the pull request

test needs to test that the import is actually made, or at least have a TODO in the code with a bug no attached to it
Attachment #824030 - Flags: review?(trifandreialin) → review-
Attached file updated the PR
Attachment #828559 - Flags: review?(florin.strugariu)
Attachment #828559 - Flags: review?(zcampbell)
Attachment #828559 - Flags: review?(trifandreialin)
Comment on attachment 828559 [details] [review]
updated the PR

just a small nit, and the pull is good to go
Attachment #828559 - Flags: review?(trifandreialin) → review-
This is a perfect example of a bug that should also be applied to v1.2. As a new test there is no question that it is applicable. Although I know it is short-term pain, the long-term gain will far exceed that pain, so I request that this bug not be closed until this test is also uplifted to v1.2. Whoever is reviewing the current PR should create a new one for v1.2 also, and request review for that.
Attachment #819715 - Attachment is obsolete: true
Attachment #824030 - Attachment is obsolete: true
Attachment #824030 - Flags: review?(zcampbell)
Attachment #824030 - Flags: review?(andrei.hutusoru)
Attachment #828559 - Flags: review?(trifandreialin)
Attachment #828559 - Flags: review?(florin.strugariu)
Attachment #828559 - Flags: review-
Attachment #828559 - Flags: review+
Comment on attachment 828559 [details] [review]
updated the PR

R+
Attachment #828559 - Flags: review?(trifandreialin) → review+
Thanks viorela!
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Attachment #828559 - Flags: review?(zcampbell)
As I am doing my audit, I see that my comment from 2 weeks ago was ignored. We should uplift this to v1.2, and I am flagging it as such.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 8339129 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14108

v1.2
Attachment #8339129 - Flags: review?(viorela.ioia)
Attachment #8339129 - Flags: review?(florin.strugariu)
Attachment #8339129 - Flags: review?(bob.silverberg)
Comment on attachment 8339129 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/14108

Landed on v1.2 in https://github.com/mozilla-b2g/gaia/commit/60c928801b32d6f0e46af2db13d1d5ef2ab6387e
Attachment #8339129 - Flags: review?(viorela.ioia)
Attachment #8339129 - Flags: review?(florin.strugariu)
Attachment #8339129 - Flags: review?(bob.silverberg)
Attachment #8339129 - Flags: review+
Status: REOPENED → RESOLVED
Closed: 9 years ago9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.