927149 - Clicking anywhere outside the stage should deselect all events

Status: RESOLVED FIXED

(Webmaker Graveyard :: Popcorn Maker, defect)

Description

[Jacob [:Jacob]]

I'd like us to make it as easy as possible to deselect all events. That way we can counterbalance potential frustration and confusion from the fact that any selected events are brought to the top during playback, regardless of actual layer order.

Right now in order to deselect all events, you have to find an empty gap in the timeline and click. This is a rather limited region, and not always available.

I suggest we allow clicking in any empty region outside of the stage to act as a deselect function for all events.

Comment 1

[Jacob [:Jacob]]

I'd like to modify to also say that we might want to go a step further and allow deselection of all events even when you click on the stage, as long as you are clicking an empty region

Comment 2

[Scott [:thecount] Downe]

Doable, and I agree.

Comment 3

[Petr Bouianov[:pbouianov]]

Attachment: https://github.com/mozilla/popcorn.webmaker.org/pull/370

Hopefully that's the area that was meant to be used for the deselection. If it should apply to a different one / more, please let me know.

Comment 4

[Matthew Schranz [:mjschranz]]

Comment on attachment 8343980 [details] [diff] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/370

This is really good, although it could be made better. For one, clicking on empty area's of the video should also trigger this and the code could be in a more sensible spot.

Consider this diff http://pastebin.mozilla.org/3743252

That removes the code you added and adds in the necessary functionality for allow this to trigger on empty area's of the video as well. Let me know if anything is confusing about that.

Comment 5

[Petr Bouianov[:pbouianov]]

Comment on attachment 8343980 [details] [diff] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/370

Updated

Comment 6

[[github robot]]

Commit pushed to master at https://github.com/mozilla/popcorn.webmaker.org

https://github.com/mozilla/popcorn.webmaker.org/commit/0de81688d9c810bbc36c6103b2a2532b2664f85f
Fix Bug 927149 - Clicking anywhere outside the stage should deselect all events