927165 - New menu can be flush too far left on initial load

Status: RESOLVED FIXED

(Webmaker Graveyard :: webmaker.org, defect)

Description

[Brett Gaylor [:brett]]

Not sure how to replicate, but discussed in IRC:

brett: hmm k88hudson
[3:09pm] brett: i didnt notice this before
[3:09pm] brett: but there is now zero margin
[3:09pm] brett: https://webmaker.mofostaging.net/
[3:09pm] brett: is that new?
[3:09pm] brett: feels new
[3:09pm] brett: oh weird
[3:09pm] k88hudson: what zero margin
[3:09pm] ericasackin joined the chat room.
[3:09pm] OpenMatt left the chat room. (Quit: Leaving.)
[3:09pm] brett: dissapears when u resize
[3:09pm] brett: wonder if i can reproduce that...
[3:09pm] k88hudson: oh yeah i know what you mean
[3:10pm] k88hudson: it's been like that for awhile, it's becaise media queries are not right for tablet
[3:10pm] k88hudson: *because
[3:10pm] brett: gotcha
[3:10pm] brett: hey a lot of people look at webmaker on an ipad i discovered
[3:10pm] k88hudson: do you want me to file that?
[3:10pm] k88hudson: yeah it really needs to be fixed

Comment 1

[inactivate account for kate]

Attachment: https://github.com/mozilla/webmaker.org/pull/433

Comment 2

[inactivate account for kate]

This basically fixes tablet styles too

Comment 4

[Jon Buckley [:jbuck]]

Comment on attachment 817507 [details] [review]
https://github.com/mozilla/webmaker.org/pull/433

Testing in Firefox I got:

* Dual height header between 769px and 1020px: http://dl.dropbox.com/u/4403845/Screenshots/af.png
* Persona button disappears at 768px and below: http://dl.dropbox.com/u/4403845/Screenshots/ag.png
* No padding present at 768px and below: http://dl.dropbox.com/u/4403845/Screenshots/ah.png

Comment 5

[Jon Buckley [:jbuck]]

Comment on attachment 817507 [details] [review]
https://github.com/mozilla/webmaker.org/pull/433

Still getting the dual height header between 769px and 1019px: http://dl.dropbox.com/u/4403845/Screenshots/ai.png

I'm also seeing some weirdness with the search bar, at 1020px it appears in the bottom bar http://dl.dropbox.com/u/4403845/Screenshots/aj.png and at >=1021px it appears in the top bar http://dl.dropbox.com/u/4403845/Screenshots/ak.png

Comment 6

[[github robot]]

Commit pushed to master at https://github.com/mozilla/webmaker.org

https://github.com/mozilla/webmaker.org/commit/e63ee7cf34292272c97fece1fb51127dbbb5800b
bug 927165: Fixes for margin/tablet display for nav, header, ui grid