Closed Bug 927174 Opened 11 years ago Closed 11 years ago

Add a link to the SUMO page from the non-vulnerable CtP doorhanger

Categories

(Core Graveyard :: Plug-ins, defect)

defect
Not set
normal

Tracking

(firefox26+ verified, firefox27 verified)

VERIFIED FIXED
mozilla27
Tracking Status
firefox26 + verified
firefox27 --- verified

People

(Reporter: lco, Assigned: benjamin)

References

Details

Attachments

(1 file)

We'd like to give users who are curious about why we're blocking non-vulnerable plugins the opportunity to get more information. Right now, the doorhanger (which appears when you click on an in-content blocked plugin or the plugin icon in the Permissions bar) just says: "Allow <site> to run <plugin>?".

Let's add a link to that message that says "Learn More...". Clicking on the link opens a SUMO article in a new tab (or window) that explains what plugins are the potential threat, and what each of the user's options mean.
Michael, can you provide a link to the SUMO page for this content?
Flags: needinfo?(mverdi)
Depends on: 927187
Please use this link:
http://support.mozilla.org/1/firefox/%VERSION%/%OS%/%LOCALE%/clicktoplay

I filed bug 927187 to have that redirected to https://support.mozilla.org/kb/why-do-i-have-click-activate-plugins which will be updated (about 4 weeks before release) with information about non-vulnerable plugins.
Flags: needinfo?(mverdi)
Comment on attachment 817895 [details] [diff] [review]
Add a "More Info..." link to the plugin click-to-activate panel which links to SUMO

Review of attachment 817895 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/app/profile/firefox.js
@@ +658,5 @@
>  pref("plugins.update.notifyUser", false);
>  
>  pref("plugins.click_to_play", true);
>  
> +pref("plugins.clickToActivateInfo.url", "http://support.mozilla.org/1/firefox/%VERSION%/%OS%/%LOCALE%/clicktoplay");

This should be https:. Please double check with mverdi to make sure that that https URL will work.
Attachment #817895 - Flags: review?(jaws) → review+
(In reply to Jared Wein [:jaws] from comment #4)
> This should be https:. Please double check with mverdi to make sure that
> that https URL will work.

Definitely should be https. I thought all in-product SUMO URLs were built off of the:

    pref("app.support.baseURL", "https://support.mozilla.org/1/firefox/%VERSION%/%OS%/%LOCALE%/");

See bug 841218, bug 922338, etc.
(In reply to Ricky Rosario [:rrosario, :r1cky] from comment #5)
> 
> Definitely should be https. I thought all in-product SUMO URLs were built
> off of the:
> 
>     pref("app.support.baseURL",
> "https://support.mozilla.org/1/firefox/%VERSION%/%OS%/%LOCALE%/");

Sorry that was my fault. I copied http from my outdated doc with the instructions on how it works. Fixed now.
https://hg.mozilla.org/integration/fx-team/rev/ed19724fff79

SUMO would like this to be included in Firefox 26.

Note that this change does not affect the case where there are multiple plugins (Java and Flash) on a page; after discussion with lco, we decided not to implement this for the multi-plugin case because there will be too many links.
Target Milestone: --- → mozilla27
Comment on attachment 817895 [details] [diff] [review]
Add a "More Info..." link to the plugin click-to-activate panel which links to SUMO

[Approval Request Comment]
Bug caused by (feature/regressing bug #): not a regression: new CtP implementation
User impact if declined: perhaps more "what is this?" when we flip the default behavior
Testing completed (on m-c, etc.): manual testing, just landed on m-c
Risk to taking this patch (and alternatives if risky): Fairly low risk
String or IDL/UUID changes made by this patch: None; this is using a string which already exists in the UI in one additional case.
Attachment #817895 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/ed19724fff79
Assignee: nobody → benjamin
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
(In reply to Ricky Rosario [:rrosario, :r1cky] from comment #5)
> (In reply to Jared Wein [:jaws] from comment #4)
> > This should be https:. Please double check with mverdi to make sure that
> > that https URL will work.
> 
> Definitely should be https. I thought all in-product SUMO URLs were built
> off of the:
> 
>     pref("app.support.baseURL",
> "https://support.mozilla.org/1/firefox/%VERSION%/%OS%/%LOCALE%/");
> 
> See bug 841218, bug 922338, etc.

Sorry for missing this. In fact, this patch should have been:
>  let url = Services.urlFormatter.formatURLPref("app.support.baseURL") + "clicktoplay";

Benjamin, do you want to fix this in a follow-up or this bug?
Flags: needinfo?(benjamin)
Attachment #817895 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Bsmedberg - carry over the a+ if you make that change from comment 10
Followup: https://hg.mozilla.org/integration/fx-team/rev/9faa8e2237db
Flags: needinfo?(benjamin)
Keywords: verifyme
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
Mozilla/5.0 (X11; Linux i686; rv:26.0) Gecko/20100101 Firefox/26.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:26.0) Gecko/20100101 Firefox/26.0

Verified as fixed on latest Aurora 26.0a2 (buildID: 20131028004004) and latest Nightly 27.0a1 (buildID: 20131028030205).
Status: RESOLVED → VERIFIED
Keywords: verifyme
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: