927179 - [traceback] Reverse for 'addons.detail' with arguments (...) not found. - when uploading a new version of an app

Status: VERIFIED FIXED

(Marketplace Graveyard :: Developer Pages, defect, P2)

Description

[(not reading bugmail) Nick Desaulniers [:\n]]

A few times now, after submitting an updated version of a packaged app, I've been taken to the "Oops, we've had an error page."  The app was packaged and privileged and had a few warnings about CSP violations.

Comment 1

[Matt Basta [:basta]]

Doubtfully validation.

cvan: Didn't you (or someone else) have this bug? I think it might have been Fabrice. You were showing me how to reproduce it a month or two ago.

Comment 2

[Christopher Van Wiemeersch [:cvan]]

http://sentry.dmz.phx1.mozilla.com/addons/marketplace-stage/group/16920/
AttributeError: 'tuple' object has no attribute 'get'

Stacktrace (most recent call last):

  File "django/core/handlers/base.py", line 111, in get_response
    response = callback(request, *callback_args, **callback_kwargs)
  File "newrelic/api/object_wrapper.py", line 216, in __call__
    self._nr_instance, args, kwargs)
  File "newrelic/hooks/framework_django.py", line 475, in wrapper
    return wrapped(*args, **kwargs)
  File "amo/decorators.py", line 157, in wrapper
    return f(*args, **kw)
  File "amo/decorators.py", line 149, in wrapper
    return f(*args, **kw)
  File "python2.6/contextlib.py", line 34, in __exit__
    self.gen.throw(type, value, traceback)
  File "amo/models.py", line 38, in skip_cache
    yield
  File "amo/decorators.py", line 149, in wrapper
    return f(*args, **kw)
  File "addons/decorators.py", line 33, in wrapper
    return f(request, addon, *args, **kw)
  File "amo/decorators.py", line 32, in wrapper
    return func(request, *args, **kw)
  File "mkt/developers/decorators.py", line 49, in wrapper
    return fun()
  File "mkt/developers/decorators.py", line 28, in <lambda>
    *args, **kw)
  File "mkt/developers/views.py", line 487, in refresh_manifest
    _update_manifest(addon_id, True, ())
  File "mkt/webapps/tasks.py", line 134, in _update_manifest
    failed_fetches[id] = failed_fetches.get(id, 0) + 1

Comment 4

[Mathieu Pillard [:mat]]

Looks like those 2 bugs are different. The actual traceback for this bug is:
http://sentry.mktmon.services.phx1.mozilla.com/mkt/marketplacefirefoxcom/group/1452/



NoReverseMatch: Reverse for 'addons.detail' with arguments '(466167L,)' and keyword arguments '{}' not found.

Stacktrace (most recent call last):

  File "django/core/handlers/base.py", line 111, in get_response
    response = callback(request, *callback_args, **callback_kwargs)
  File "amo/decorators.py", line 157, in wrapper
    return f(*args, **kw)
  File "amo/decorators.py", line 149, in wrapper
    return f(*args, **kw)
  File "addons/decorators.py", line 33, in wrapper
    return f(request, addon, *args, **kw)
  File "amo/decorators.py", line 32, in wrapper
    return func(request, *args, **kw)
  File "mkt/developers/decorators.py", line 49, in wrapper
    return fun()
  File "mkt/developers/decorators.py", line 28, in <lambda>
    *args, **kw)
  File "mkt/developers/views.py", line 223, in status
    addon, [amo.PLATFORM_ALL])
  File "versions/models.py", line 152, in from_upload
    version_uploaded.send(sender=v)
  File "django/dispatch/dispatcher.py", line 172, in send
    response = receiver(signal=self, sender=sender, **named)
  File "editors/models.py", line 323, in send_notifications
    subscriber.send_notification(sender)
  File "editors/models.py", line 298, in send_notification
    add_prefix=False)),
  File "amo/urlresolvers.py", line 62, in reverse
    url = django_reverse(viewname, urlconf, args, kwargs, prefix, current_app)
  File "django/core/urlresolvers.py", line 476, in reverse
    return iri_to_uri(resolver._reverse_with_prefix(view, prefix, *args, **kwargs))
  File "django/core/urlresolvers.py", line 396, in _reverse_with_prefix
    "arguments '%s' not found." % (lookup_view_s, args, kwargs))



First impressions: it doesn't make any sense.

Comment 5

[Mathieu Pillard [:mat]]

We should never reverse addons.detail in Marketplace... But we do here. This happens because we send a signal that is caught by AMO-specific code. I'll untangle this mess to figure out why this only happens sometimes, it's possible we only started seeing this because of the safe_signals removing in bug 865769.

Comment 6

[Mathieu Pillard [:mat]]

This is caused by reviewers subscribing to receive emails when new versions of an app is uploaded even though the feature is only half-implemented at the moment. It will be in bug 741679. I've added code to prevent the failure in the meantime: https://github.com/mozilla/zamboni/pull/1269

Comment 7

[Mathieu Pillard [:mat]]

Fixed in https://github.com/mozilla/zamboni/commit/3a513aac7482377e4756be90db6679a65f28a726

STR:
- Submit a packaged app on -dev
- Then go to review it, but check "Notify me the next time the manifest is updated" before pushing it to public
- Upload a new version of the app
- You should not get an error (you shouldn't be notified either - that checkbox actually doesn't work, we are only checking that it doesn't generate an error later)

Comment 8

[Victor Carciu]

Verified as fixed : http://screencast.com/t/TWCI9Nmuh8