927238 - Defect - Dropdowns appear cut off and are not selectable with keyboard shortcuts and flash on/off

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: General, defect, P2)

Description

[donrhummy]

User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:27.0) Gecko/20100101 Firefox/27.0 (Beta/Release)
Build ID: 20130929030202

Steps to reproduce:

Went to partycity.com and in checkout (entering credit card info, state, expiration date, etc) tried to select values in a dropdown both with keyboard and mouse.


Actual results:

1. When selecting with up/down arrows, every change, the entire dropdown flashed to invisible and then back to visible.

2. After selecting a value with the keyboard arrows, neither "enter" or "tab" selected the value or moved to the next

3. Even scrolling up/down with a finger or mouse caused some flashing


Expected results:

It should have worked perfectly like a normal HTML component

Comment 1

[Sam Foster [:sfoster] (he/him)]

Attachment: Walk up to to the list item when handling click events in SelectHelperUI

Most of the symptoms described here are fixed by the patch on bug 919232.
This patch just fixes a newly revealed issue where SelectHelperUI.onSelect was not getting called when tapping on a menu item, resulting in multiple selections in a single-select control.

Comment 2

[Rodrigo Silveira [:rsilveira] [:rodms]]

Comment on attachment 826147 [details] [diff] [review]
Walk up to to the list item when handling click events in SelectHelperUI

Review of attachment 826147 [details] [diff] [review]:
-----------------------------------------------------------------

As discussed on IRC, it would be cleaner to do a pointer-events: none; on the label.

Comment 3

[Sam Foster [:sfoster] (he/him)]

Attachment: Fix event target for select option clicks

I scoped the selector to just fix this for #select-commands options, I'm not 100% sure if this can be broadened to all .option-command > label so I'd rather do that in a follow-up if it becomes necessary.

Comment 4

[Rodrigo Silveira [:rsilveira] [:rodms]]

Comment on attachment 826187 [details] [diff] [review]
Fix event target for select option clicks

Review of attachment 826187 [details] [diff] [review]:
-----------------------------------------------------------------

Sounds good.

Comment 5

[Marco Mucci [:MarcoM]]

Hey Sam, saw your note in Comment #1 and adjusted the Defect accordingly.  Please provide a point value for this Defect.  Thanks.

Comment 6

[Sam Foster [:sfoster] (he/him)]

:marco, its a 1 pointer.

Comment 7

[Sam Foster [:sfoster] (he/him)]

On fx-team: https://hg.mozilla.org/integration/fx-team/rev/547c6caec56f

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/547c6caec56f

Comment 9

[Cornel Ionce [:noni] [Hubs QA]]

Mozilla/5.0 (Windows NT 6.2; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0
Mozilla/5.0 (Windows NT 6.2; rv:28.0) Gecko/20100101 Firefox/28.0

Build ID: 20131114030204


I still got the following issues while testing this:

- when selecting a value with the keyboard arrows, holding the "Up" or "Down" key pressed it will make the dropdown disappear (but the values are scrolled)
- "enter" has to be pressed twice to select a value
- "tab" selects the value but does not move to the next box.

Tested using a checkout (as guest) at partycity.com with the State dropdown.

Comment 10

[Marco Mucci [:MarcoM]]

Hi Cornel, can you file a separate bug for the issue you are encountering.  Thanks.

Comment 11

[Cornel Ionce [:noni] [Hubs QA]]

(In reply to Marco Mucci [:MarcoM] from comment #10)
> Hi Cornel, can you file a separate bug for the issue you are encountering. 
> Thanks.

Filled bug 939689 for the remaining issues and CC'ed you.

I think we can consider this verified.