Defect - Dropdowns appear cut off and are not selectable with keyboard shortcuts and flash on/off

VERIFIED FIXED in Firefox 28

Status

defect
P2
normal
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: donrhummy, Assigned: sfoster)

Tracking

24 Branch
Firefox 28
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [block28] feature=defect c=tbd u=tbd p=1)

Attachments

(1 attachment, 1 obsolete attachment)

Reporter

Description

6 years ago
User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:27.0) Gecko/20100101 Firefox/27.0 (Beta/Release)
Build ID: 20130929030202

Steps to reproduce:

Went to partycity.com and in checkout (entering credit card info, state, expiration date, etc) tried to select values in a dropdown both with keyboard and mouse.


Actual results:

1. When selecting with up/down arrows, every change, the entire dropdown flashed to invisible and then back to visible.

2. After selecting a value with the keyboard arrows, neither "enter" or "tab" selected the value or moved to the next

3. Even scrolling up/down with a finger or mouse caused some flashing


Expected results:

It should have worked perfectly like a normal HTML component
Summary: Dropdowns appear cut off and are not selectable with keyboard shortcuts and flash on/off → Defect - Dropdowns appear cut off and are not selectable with keyboard shortcuts and flash on/off
Whiteboard: [triage] feature=defect c=tbd u=tbd p=0
Whiteboard: [triage] feature=defect c=tbd u=tbd p=0 → feature=defect c=tbd u=tbd p=0
Whiteboard: feature=defect c=tbd u=tbd p=0 → [release28] feature=defect c=tbd u=tbd p=0
Assignee

Updated

6 years ago
Blocks: 855434
Assignee

Comment 1

6 years ago
Most of the symptoms described here are fixed by the patch on bug 919232.
This patch just fixes a newly revealed issue where SelectHelperUI.onSelect was not getting called when tapping on a menu item, resulting in multiple selections in a single-select control.
Assignee: nobody → sfoster
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #826147 - Flags: review?(rsilveira)
Comment on attachment 826147 [details] [diff] [review]
Walk up to to the list item when handling click events in SelectHelperUI

Review of attachment 826147 [details] [diff] [review]:
-----------------------------------------------------------------

As discussed on IRC, it would be cleaner to do a pointer-events: none; on the label.
Attachment #826147 - Flags: review?(rsilveira) → review-
Assignee

Comment 3

6 years ago
I scoped the selector to just fix this for #select-commands options, I'm not 100% sure if this can be broadened to all .option-command > label so I'd rather do that in a follow-up if it becomes necessary.
Attachment #826147 - Attachment is obsolete: true
Attachment #826187 - Flags: review?(rsilveira)
Comment on attachment 826187 [details] [diff] [review]
Fix event target for select option clicks

Review of attachment 826187 [details] [diff] [review]:
-----------------------------------------------------------------

Sounds good.
Attachment #826187 - Flags: review?(rsilveira) → review+
Hey Sam, saw your note in Comment #1 and adjusted the Defect accordingly.  Please provide a point value for this Defect.  Thanks.
Blocks: metrov1it18, 919232
No longer blocks: metrov1backlog, 855434
Flags: needinfo?(sfoster)
Priority: -- → P2
QA Contact: jbecerra
Whiteboard: [release28] feature=defect c=tbd u=tbd p=0 → [block28] feature=defect c=tbd u=tbd p=0
Assignee

Comment 6

6 years ago
:marco, its a 1 pointer.
Flags: needinfo?(sfoster)
Assignee

Updated

6 years ago
Whiteboard: [block28] feature=defect c=tbd u=tbd p=0 → [block28] feature=defect c=tbd u=tbd p=1
https://hg.mozilla.org/mozilla-central/rev/547c6caec56f
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 28
Mozilla/5.0 (Windows NT 6.2; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0
Mozilla/5.0 (Windows NT 6.2; rv:28.0) Gecko/20100101 Firefox/28.0

Build ID: 20131114030204


I still got the following issues while testing this:

- when selecting a value with the keyboard arrows, holding the "Up" or "Down" key pressed it will make the dropdown disappear (but the values are scrolled)
- "enter" has to be pressed twice to select a value
- "tab" selects the value but does not move to the next box.

Tested using a checkout (as guest) at partycity.com with the State dropdown.
Hi Cornel, can you file a separate bug for the issue you are encountering.  Thanks.
Flags: needinfo?(cornel.ionce)
(In reply to Marco Mucci [:MarcoM] from comment #10)
> Hi Cornel, can you file a separate bug for the issue you are encountering. 
> Thanks.

Filled bug 939689 for the remaining issues and CC'ed you.

I think we can consider this verified.
Status: RESOLVED → VERIFIED
Flags: needinfo?(cornel.ionce)
You need to log in before you can comment on or make changes to this bug.