927240 - Support ANDed filtering in MozTrap

Status: RESOLVED WONTFIX

(Mozilla QA Graveyard :: MozTrap, defect)

Description

[shiro Bai [:shiro]]

+++ This bug was initially created as a clone of Bug #900678 +++

I'm going to release an experimental patch to support ANDed tags filtering.
If possible, ANDed product version, creator etc. will be supported later.

Currently in MozTrap, query foramt in GET method is like filter-tag=246&filter-tag=2114&filter-productversion=103.
And filter conditions in the same group will be merged into a list and perform a SELECT IN SQL query, e.g. SELECT ... WHERE tags in (246, 2114), thus the result is ORed.

My approach:
Try to support new kinds of tag formats in URL GET method, like filter-and-tag, filter-and-product, etc.
With these tags specified in url, the ANDed filtering will be performed in the corresponding filter group instead.

Comment 1

[shiro Bai [:shiro]]

Attachment: pr

https://github.com/mozilla/moztrap/pull/38

Can you help to review the patch?
Thanks

Comment 2

[shiro Bai [:shiro]]

Usage:
First, copy the shraing link of your query.
Then append &filter-and-<key> (e.g. &filter-and-tag) to the link.
Use the modified link to open the ANDed result page.

Support keys: tag, product, productversion, creator, suite, run, envelement...

Comment 3

[shiro Bai [:shiro]]

Hi Matt,
Could you please help review?

Thanks

Comment 4

[shiro Bai [:shiro]]

Attachment: support ANDed filtering

https://github.com/mozilla/moztrap/pull/40

I resend a pull request since I move this bug patch to a new branch

Comment 5

[Rebecca Billings [:rbillings]]

Hi shiro - thanks for the pull request. I'll take a look at it, but it needs other review. The rest of the team is on vacation, so please be patient with us.

Comment 6

[Cameron Dawson [:camd]]

Here's my comment from github in the PR:

@sh1r0 : I am actually not able to get this to work for me, locally. Is this what you had in mind for the url?
http://localhost:8000/manage/cases/?filter-and-tag=8&filter-and-tag=7

I was expecting it to show me only cases with BOTH of those tags. But it seems as though it's not doing any filtering at all. Would you double-check this still works for you? Thanks!

Comment 7

[Cameron Dawson [:camd]]

Comment on attachment 819629 [details] [review]
support ANDed filtering

Shiro decided to drop this feature

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Mass-closing remaining MozTrap bugs as WONTFIX, due to 1) the Mozilla-hosted instance being decommissioned (see https://wiki.mozilla.org/TestEngineering/Testrail), and, for now, 2) the still-up code archived at its GitHub page: https://github.com/mozilla/moztrap (we'll decide what's next for that, in the near future).

See also the history and more-detailed discussion which led us here, at https://groups.google.com/forum/#!topic/mozilla.dev.quality/Sa75hV8Ywvk

(If you'd like, you should be able to filter these notification emails using at least the unique string of "Sa75hV8Ywvk" in the message body.

Thanks!