927345 - The sorting of video group in gallery view is not correct.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Video, defect)

Description

[John Hu [:johnhu][:johu][:醬糊小弟]]

Attachment: wrong list

The video group is not sorted descending, see the attachment.

STR:
  1. open video app
  2. switch to settings app and change the date to september
  3. make a video with camera app
  4. change the date to october in settings app
  5. make a video with camera app
  6. open video app and find the september is at top of october  <== KO

Comment 1

[John Hu [:johnhu][:johu][:醬糊小弟]]

Mark this as regression. I think this bug is created by my patch.

Comment 2

[Jason Smith [:jsmith]]

How critical is it that video sorting is working? Wondering if this needs to be nomed to block or not, as we normally block on any non-minor regression.

Comment 3

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

This patch has updated display of month for group id and some of the test cases.

Comment 4

[John Hu [:johnhu][:johu][:醬糊小弟]]

Jason,

I don't know how to describe the how critical it is. You may see the screenshot where the september group is ordered higher than october group. So, it should be a visual impact. But the functions are still correct.

Comment 5

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 818149 [details]
PR to master

Thanks for this patch, George. r=me

Comment 6

[(Inactive after June) George Duan [:gduan] [:喬智]]

Thanks,
merge into master,
https://github.com/mozilla-b2g/gaia/commit/32a49559380c093e7048611316dd656543affe66

Comment 7

[Jason Smith [:jsmith]]

Given this is a regression, it might be worthwhile to ask for approval here.

Comment 8

[John Hu [:johnhu][:johu][:醬糊小弟]]

Thanks. I nominate it as koi?.

Comment 9

[Jason Smith [:jsmith]]

(In reply to John Hu [:johnhu] from comment #8)
> Thanks. I nominate it as koi?.

Well, that means asking for approval-gaia-v1.2, not koi?

Comment 10

[Hema Koka [:hema]]

Comment on attachment 818149 [details]
PR to master

Approving patch for 1.2

Comment 11

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 32a49559380c093e7048611316dd656543affe66 to:
v1.2: 663fc6a5d802314c93e0e899fe06fbc6fe622730

Comment 12

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 32a49559380c093e7048611316dd656543affe66 to:
v1.3 already had this commit