927400 - Make it easier on development masters when a new platform is added to BuildSlaves.py

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Armen [:armenzg]]

Attachment: screen_resolution.diff

Comment 1

[[e-mail] (:bhearsum)]

Comment on attachment 817831 [details] [diff] [review]
screen_resolution.diff

Review of attachment 817831 [details] [diff] [review]:
-----------------------------------------------------------------

Did you attach the right patch? Or did you post this in the wrong bug?

Comment 2

[Armen [:armenzg]]

Attachment: platforms.diff

Comment 3

[[e-mail] (:bhearsum)]

Comment on attachment 817979 [details] [diff] [review]
platforms.diff

Review of attachment 817979 [details] [diff] [review]:
-----------------------------------------------------------------

I worry that this will make it more likely that we'll forget to update BuildSlaves.py in Puppet. Is it really that burdensome to update BuildSlaves.py.template/your local dev master copy?

Comment 4

[[e-mail] (:bhearsum)]

The consequences of not updating the Puppet one aren't that dire though...so maybe I don't care.

Comment 5

[Armen [:armenzg]]

We don't update dev-master01 with puppet.
It does get annoying plus it is something that new people hit easily and take them while to realize what is going on.

r?

Comment 6

[[e-mail] (:bhearsum)]

(In reply to Armen Zambrano [:armenzg] (Release Engineering) (EDT/UTC-4) from comment #5)
> We don't update dev-master01 with puppet.
> It does get annoying plus it is something that new people hit easily and
> take them while to realize what is going on.
> 
> r?

Right...I'm talking about forgetting to update the _production_ BuildSlaves.py. The fact that you end up with missing entries on dev-master is a good prompt to update it. With this patch, we lose that prompt and we're more likely to forget to make that change ahead of the reconfig.

Meh.

Comment 7

[Armen [:armenzg]]

Comment on attachment 817979 [details] [diff] [review]
platforms.diff

https://hg.mozilla.org/build/buildbot-configs/rev/3eedc2a59c84

This only affects universal_master_sqlite.cfg which is not used by the production masters IIUC.

Comment 8

[Armen [:armenzg]]

I assume this went live 3 hours ago with:
http://hg.mozilla.org/build/buildbot-configs/rev/c586441d439c