Closed
Bug 927400
Opened 9 years ago
Closed 9 years ago
Make it easier on development masters when a new platform is added to BuildSlaves.py
Categories
(Release Engineering :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: armenzg, Assigned: armenzg)
Details
Attachments
(1 file, 1 obsolete file)
1.65 KB,
patch
|
bhearsum
:
review+
armenzg
:
checked-in+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #817831 -
Flags: review?(bhearsum)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → armenzg
Comment 1•9 years ago
|
||
Comment on attachment 817831 [details] [diff] [review] screen_resolution.diff Review of attachment 817831 [details] [diff] [review]: ----------------------------------------------------------------- Did you attach the right patch? Or did you post this in the wrong bug?
Assignee | ||
Comment 2•9 years ago
|
||
Attachment #817831 -
Attachment is obsolete: true
Attachment #817831 -
Flags: review?(bhearsum)
Attachment #817979 -
Flags: review?(bhearsum)
Comment 3•9 years ago
|
||
Comment on attachment 817979 [details] [diff] [review] platforms.diff Review of attachment 817979 [details] [diff] [review]: ----------------------------------------------------------------- I worry that this will make it more likely that we'll forget to update BuildSlaves.py in Puppet. Is it really that burdensome to update BuildSlaves.py.template/your local dev master copy?
Comment 4•9 years ago
|
||
The consequences of not updating the Puppet one aren't that dire though...so maybe I don't care.
Assignee | ||
Comment 5•9 years ago
|
||
We don't update dev-master01 with puppet. It does get annoying plus it is something that new people hit easily and take them while to realize what is going on. r?
Comment 6•9 years ago
|
||
(In reply to Armen Zambrano [:armenzg] (Release Engineering) (EDT/UTC-4) from comment #5) > We don't update dev-master01 with puppet. > It does get annoying plus it is something that new people hit easily and > take them while to realize what is going on. > > r? Right...I'm talking about forgetting to update the _production_ BuildSlaves.py. The fact that you end up with missing entries on dev-master is a good prompt to update it. With this patch, we lose that prompt and we're more likely to forget to make that change ahead of the reconfig. Meh.
Updated•9 years ago
|
Attachment #817979 -
Flags: review?(bhearsum) → review+
Assignee | ||
Comment 7•9 years ago
|
||
Comment on attachment 817979 [details] [diff] [review] platforms.diff https://hg.mozilla.org/build/buildbot-configs/rev/3eedc2a59c84 This only affects universal_master_sqlite.cfg which is not used by the production masters IIUC.
Attachment #817979 -
Flags: checked-in+
Assignee | ||
Comment 8•9 years ago
|
||
I assume this went live 3 hours ago with: http://hg.mozilla.org/build/buildbot-configs/rev/c586441d439c
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Updated•5 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•