Closed Bug 927404 Opened 10 years ago Closed 10 years ago

Logs are no longer displayed for failing tests

Categories

(Remote Protocol :: Marionette, defect)

Product:
Remote Protocol
Component:
Marionette
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: AlinT, Assigned: jgriffin)

References

Details

Attachments

(2 files)

Screenshot of the issue
47.17 KB, image/png
Details
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12902
358 bytes, text/html
zcampbell
: review+
davehunt
: review+
Details
Attached image Screenshot of the issue — 
STR:
Take a failing python functional tests and run it(or modify any test so that it fails when run) from the gaia-ui-tests folder: https://github.com/mozilla-b2g/gaia/tree/master/tests/python/gaia-ui-tests/gaiatest/tests

Expected results:
A log for the fail/error should be displayed in the terminal/console.

Actual results:
No log is displayed in the the termina/console.

Environment:
ManifestDestiny==0.5.7
argparse==1.2.1
gaiatest==0.17
marionette-client==0.6.0 <<--
mozcrash==0.8
mozdevice==0.29
mozfile==0.11
mozhttpd==0.6
mozinfo==0.6
mozlog==1.3
moznetwork==0.23
mozprocess==0.11
mozprofile==0.15
mozrunner==5.24
moztest==0.3
py==1.4.14
requests==2.0.0
wsgiref==0.1.2

Build id:
Gecko  http://hg.mozilla.org/mozilla-central/rev/9f63bbc00527
Gaia  3d4f1107e6e91e5f5649edc0f2565ac837111d7d
BuildID 20131016040202
Version 27.0a1
I'll try to reproduce this; it could possibly have something to do with the recent moztest integration.
I have tried to reproduce this in m-c against desktop, since it shouldnt really matter if marionette is the cause and I couldnt

(927404)☁  marionette  python runtests.py tests/unit-tests.ini --binary ../../../../obj-ff-dbg/dist/Nightly.app/Contents/MacOS/firefox --type=browser

ROUND 0
-------
starting httpd
running webserver on http://192.168.1.2:59429/
TEST-START test_getstatus.py
test_getStatus (test_getstatus.TestGetStatus) ... ok

----------------------------------------------------------------------
Ran 1 test in 0.057s

OK
TEST-START test_import_script.py
test_import_script (test_import_script.TestImportScript) ... ok
test_importing_another_script_and_check_they_append (test_import_script.TestImportScript) ... ok
test_import_script (test_import_script.TestImportScriptChrome) ... ok
test_importing_another_script_and_check_they_append (test_import_script.TestImportScriptChrome) ... ok

----------------------------------------------------------------------
Ran 4 tests in 0.265s

OK
TEST-START test_import_script_reuse_window.py
test_importing_script_then_reusing_it (test_import_script_reuse_window.TestImportScriptContent) ... ok

----------------------------------------------------------------------
Ran 1 test in 0.387s

OK
TEST-START test_click.py
testClickingALinkMadeUpOfNumbersIsHandledCorrectly (test_click.TestClick) ... ok
test_click (test_click.TestClick) ... ok

----------------------------------------------------------------------
Ran 2 tests in 1.430s

OK
TEST-START test_click_chrome.py
test_click (test_click_chrome.TestClickChrome) ... ok

----------------------------------------------------------------------
Ran 1 test in 0.123s

OK
TEST-START test_selected.py
test_selected (test_selected.TestSelected) ... ok

----------------------------------------------------------------------
Ran 1 test in 0.192s

OK
TEST-START test_selected_chrome.py
test_selected (test_selected_chrome.TestSelectedChrome) ... ok

----------------------------------------------------------------------
Ran 1 test in 0.113s

OK
TEST-START test_getattr.py
test_getAttribute (test_getattr.TestGetAttribute) ... ok
test_that_we_can_return_a_boolean_attribute_correctly (test_getattr.TestGetAttribute) ... ok

----------------------------------------------------------------------
Ran 2 tests in 0.389s

OK
TEST-START test_getattr_chrome.py
test_getAttribute (test_getattr_chrome.TestGetAttributeChrome) ... ok

----------------------------------------------------------------------
Ran 1 test in 0.137s

OK
TEST-START test_elementState.py
test_isDisplayed (test_elementState.TestState) ... ok
test_isEnabled (test_elementState.TestState) ... ok

----------------------------------------------------------------------
Ran 2 tests in 0.412s

OK
TEST-START test_elementState_chrome.py
test_isEnabled (test_elementState_chrome.TestStateChrome) ... ok

----------------------------------------------------------------------
Ran 1 test in 0.113s

OK
TEST-START test_text.py
test_clearText (test_text.TestText) ... ok
test_getText (test_text.TestText) ... ok
test_sendKeys (test_text.TestText) ... ok

----------------------------------------------------------------------
Ran 3 tests in 0.644s

OK
TEST-START test_log.py
test_log_basic (test_log.TestLog) ... ok
test_log_script (test_log.TestLog) ... ok
test_that_we_can_clear_the_logs (test_log.TestLog) ... ok
test_log_basic (test_log.TestLogChrome) ... ok
test_log_script (test_log.TestLogChrome) ... ok
test_that_we_can_clear_the_logs (test_log.TestLogChrome) ... ok

----------------------------------------------------------------------
Ran 6 tests in 0.494s

OK
TEST-START test_execute_async_script.py
test_check_window (test_execute_async_script.TestExecuteAsyncChrome) ... ok
test_execute_async_js_exception (test_execute_async_script.TestExecuteAsyncChrome) ... ok
test_execute_async_ours (test_execute_async_script.TestExecuteAsyncChrome) ... ok
test_execute_async_simple (test_execute_async_script.TestExecuteAsyncChrome) ... ok
test_execute_async_timeout (test_execute_async_script.TestExecuteAsyncChrome) ... ok
test_execute_async_unique_timeout (test_execute_async_script.TestExecuteAsyncChrome) ... ok
test_execute_async_unload (test_execute_async_script.TestExecuteAsyncChrome) ... ok
test_execute_js_exception (test_execute_async_script.TestExecuteAsyncChrome) ... ok
test_execute_no_return (test_execute_async_script.TestExecuteAsyncChrome) ... ok
test_execute_permission (test_execute_async_script.TestExecuteAsyncChrome) ... ok
test_no_timeout (test_execute_async_script.TestExecuteAsyncChrome) ... ok
test_same_context (test_execute_async_script.TestExecuteAsyncChrome) ... ok
test_sandbox_reuse (test_execute_async_script.TestExecuteAsyncChrome) ... ok
test_script_finished (test_execute_async_script.TestExecuteAsyncChrome) ... ok
test_check_window (test_execute_async_script.TestExecuteAsyncContent) ... ok
test_execute_async_js_exception (test_execute_async_script.TestExecuteAsyncContent) ... ok
test_execute_async_ours (test_execute_async_script.TestExecuteAsyncContent) ... ok
test_execute_async_simple (test_execute_async_script.TestExecuteAsyncContent) ... ok
test_execute_async_timeout (test_execute_async_script.TestExecuteAsyncContent) ... ok
test_execute_async_unique_timeout (test_execute_async_script.TestExecuteAsyncContent) ... ok
test_execute_async_unload (test_execute_async_script.TestExecuteAsyncContent) ... ok
test_execute_js_exception (test_execute_async_script.TestExecuteAsyncContent) ... ok
test_execute_no_return (test_execute_async_script.TestExecuteAsyncContent) ... ok
test_execute_permission (test_execute_async_script.TestExecuteAsyncContent) ... ok
test_no_timeout (test_execute_async_script.TestExecuteAsyncContent) ... ok
test_same_context (test_execute_async_script.TestExecuteAsyncContent) ... ok
test_sandbox_reuse (test_execute_async_script.TestExecuteAsyncContent) ... ok
test_script_finished (test_execute_async_script.TestExecuteAsyncContent) ... ok

----------------------------------------------------------------------
Ran 28 tests in 11.074s

OK
TEST-START test_execute_script.py
test_check_window (test_execute_script.TestExecuteChrome) ... ok
test_complex_return_values (test_execute_script.TestExecuteChrome) ... ok
test_execute_js_exception (test_execute_script.TestExecuteChrome) ... ok
test_execute_no_return (test_execute_script.TestExecuteChrome) ... ok
test_execute_permission (test_execute_script.TestExecuteChrome) ... ok
test_execute_simple (test_execute_script.TestExecuteChrome) ... ok
test_sandbox_reuse (test_execute_script.TestExecuteChrome) ... ok
test_stack_trace (test_execute_script.TestExecuteChrome) ... ok
test_that_we_can_pass_in_floats (test_execute_script.TestExecuteChrome) ... ok
test_check_window (test_execute_script.TestExecuteContent) ... ok
test_complex_return_values (test_execute_script.TestExecuteContent) ... ok
test_execute_js_exception (test_execute_script.TestExecuteContent) ... ok
test_execute_no_return (test_execute_script.TestExecuteContent) ... ok
test_execute_permission (test_execute_script.TestExecuteContent) ... ok
test_execute_simple (test_execute_script.TestExecuteContent) ... ok
test_sandbox_reuse (test_execute_script.TestExecuteContent) ... ok
test_stack_trace (test_execute_script.TestExecuteContent) ... ok
test_that_we_can_pass_in_floats (test_execute_script.TestExecuteContent) ... ok

----------------------------------------------------------------------
Ran 18 tests in 1.306s

OK
TEST-START test_simpletest_fail.js
/Users/dburns/development/mozilla/mozilla-inbound/testing/marionette/client/marionette/tests/unit/test_simpletest_fail.js, runTest (marionette_test.MarionetteJSTestCase) ... ok

----------------------------------------------------------------------
Ran 1 test in 0.290s

OK
TEST-START test_findelement.py
test_by_name (test_findelement.TestElements) ... ok
test_child_element (test_findelement.TestElements) ... ok
test_child_elements (test_findelement.TestElements) ... ok
test_class_name (test_findelement.TestElements) ... ok
test_css_selector_scope_doesnt_start_at_rootnode (test_findelement.TestElements) ... ok
test_finding_active_element_returns_element (test_findelement.TestElements) ... ok
test_id (test_findelement.TestElements) ... ok
test_link_text (test_findelement.TestElements) ... ok
test_not_found (test_findelement.TestElements) ... ok
test_partial_link_text (test_findelement.TestElements) ... ok
test_selector (test_findelement.TestElements) ... ok
test_tag_name (test_findelement.TestElements) ... ok
test_timeout (test_findelement.TestElements) ... ok
test_xpath (test_findelement.TestElements) ... ok

----------------------------------------------------------------------
Ran 14 tests in 4.822s

OK
TEST-START test_findelement_chrome.py
test_child_element (test_findelement_chrome.TestElementsChrome) ... ok
test_child_elements (test_findelement_chrome.TestElementsChrome) ... ok
test_class_name (test_findelement_chrome.TestElementsChrome) ... ok
test_id (test_findelement_chrome.TestElementsChrome) ... ok
test_not_found (test_findelement_chrome.TestElementsChrome) ... ok
test_tag_name (test_findelement_chrome.TestElementsChrome) ... ok
test_timeout (test_findelement_chrome.TestElementsChrome) ... ok
test_xpath (test_findelement_chrome.TestElementsChrome) ... ok

----------------------------------------------------------------------
Ran 8 tests in 2.893s

OK
TEST-START test_navigation.py
test_find_element_state_complete (test_navigation.TestNavigate) ... ok
test_getUrl (test_navigation.TestNavigate) ... ok
test_goBack (test_navigation.TestNavigate) ... ok
test_goForward (test_navigation.TestNavigate) ... ok
test_navigate (test_navigation.TestNavigate) ... ok
test_navigate_frame (test_navigation.TestNavigate) ... ok
test_navigate_iframe (test_navigation.TestNavigate) ... ok
test_refresh (test_navigation.TestNavigate) ... ok
test_should_throw_a_timeoutexception_when_loading_page (test_navigation.TestNavigate) ... ok
test_shouldnt_error_if_nonexistent_url_used (test_navigation.TestNavigate) ... ok

----------------------------------------------------------------------
Ran 10 tests in 2.511s

OK
TEST-START test_timeouts.py
test_execute_async_timeout_settimeout (test_timeouts.TestTimeouts) ... ok
test_no_timeout_settimeout (test_timeouts.TestTimeouts) ... ok
test_pagetimeout_fail (test_timeouts.TestTimeouts) ... ok
test_pagetimeout_notdefinetimeout_pass (test_timeouts.TestTimeouts) ... ok
test_pagetimeout_pass (test_timeouts.TestTimeouts) ... ok
test_searchtimeout_found (test_timeouts.TestTimeouts) ... ok
test_searchtimeout_found_settimeout (test_timeouts.TestTimeouts) ... ok
test_searchtimeout_notfound_settimeout (test_timeouts.TestTimeouts) ... ok

----------------------------------------------------------------------
Ran 8 tests in 13.768s

OK
TEST-START test_single_finger_desktop.py
test_chain (test_single_finger_desktop.testSingleFingerMouse) ... ok
test_chain_flick (test_single_finger_desktop.testSingleFingerMouse) ... ok
test_context_menu (test_single_finger_desktop.testSingleFingerMouse) ... ok
test_double_tap (test_single_finger_desktop.testSingleFingerMouse) ... ok
test_long_press_action (test_single_finger_desktop.testSingleFingerMouse) ... ok
test_move_by_offset (test_single_finger_desktop.testSingleFingerMouse) ... ok
test_move_element (test_single_finger_desktop.testSingleFingerMouse) ... ok
test_press_release (test_single_finger_desktop.testSingleFingerMouse) ... ok
test_single_tap (test_single_finger_desktop.testSingleFingerMouse) ... ok
test_wait (test_single_finger_desktop.testSingleFingerMouse) ... ok
test_wait_with_value (test_single_finger_desktop.testSingleFingerMouse) ... ok

----------------------------------------------------------------------
Ran 11 tests in 17.129s

OK
TEST-START test_simpletest_pass.js
/Users/dburns/development/mozilla/mozilla-inbound/testing/marionette/client/marionette/tests/unit/test_simpletest_pass.js, runTest (marionette_test.MarionetteJSTestCase) ... ok

----------------------------------------------------------------------
Ran 1 test in 0.283s

OK
TEST-START test_simpletest_sanity.py
test_is (test_simpletest_sanity.SimpletestSanityTest) ... ok
test_isnot (test_simpletest_sanity.SimpletestSanityTest) ... ok
test_ok (test_simpletest_sanity.SimpletestSanityTest) ... ok

----------------------------------------------------------------------
Ran 3 tests in 0.300s

OK
TEST-START test_simpletest_chrome.js
/Users/dburns/development/mozilla/mozilla-inbound/testing/marionette/client/marionette/tests/unit/test_simpletest_chrome.js, runTest (marionette_test.MarionetteJSTestCase) ... ok

----------------------------------------------------------------------
Ran 1 test in 0.066s

OK
TEST-START test_simpletest_timeout.js
/Users/dburns/development/mozilla/mozilla-inbound/testing/marionette/client/marionette/tests/unit/test_simpletest_timeout.js, runTest (marionette_test.MarionetteJSTestCase) ... ok

----------------------------------------------------------------------
Ran 1 test in 0.281s

OK
TEST-START test_specialpowers.py
test_prefs (test_specialpowers.TestSpecialPowersChrome) ... ok
test_prefs_after_navigate (test_specialpowers.TestSpecialPowersChrome) ... ok
test_prefs (test_specialpowers.TestSpecialPowersContent) ... ok
test_prefs_after_navigate (test_specialpowers.TestSpecialPowersContent) ... ok

----------------------------------------------------------------------
Ran 4 tests in 0.391s

OK
TEST-START test_switch_frame.py
testShouldAllowAUserToSwitchFromAnIframeBackToTheMainContentOfThePage (test_switch_frame.TestSwitchFrame) ... ok
testShouldBeAbleToCarryOnWorkingIfTheFrameIsDeletedFromUnderUs (test_switch_frame.TestSwitchFrame) ... ok
test_stack_trace (test_switch_frame.TestSwitchFrame) ... ok
test_switch_nested (test_switch_frame.TestSwitchFrame) ... ok
test_switch_simple (test_switch_frame.TestSwitchFrame) ... ok

----------------------------------------------------------------------
Ran 5 tests in 3.037s

OK
TEST-START test_switch_frame_chrome.py
test_stack_trace (test_switch_frame_chrome.TestSwitchFrameChrome) ... ok
test_switch_simple (test_switch_frame_chrome.TestSwitchFrameChrome) ... ok

----------------------------------------------------------------------
Ran 2 tests in 1.089s

OK
TEST-START test_switch_remote_frame.py
test_remote_frame (test_switch_remote_frame.TestSwitchRemoteFrame) ... ok
test_remote_frame_revisit (test_switch_remote_frame.TestSwitchRemoteFrame) ... ok

----------------------------------------------------------------------
Ran 2 tests in 0.860s

OK
TEST-START test_visibility.py
testHiddenInputElementsAreNeverVisible (test_visibility.TestVisibility) ... ok
testShouldAllowTheUserToTellIfAnElementIsDisplayedOrNot (test_visibility.TestVisibility) ... ok
testShouldClickOnELementPartiallyOffBottom (test_visibility.TestVisibility) ... ok
testShouldClickOnELementPartiallyOffLeft (test_visibility.TestVisibility) ... ok
testShouldClickOnELementPartiallyOffRight (test_visibility.TestVisibility) ... ok
testShouldClickOnELementPartiallyOffTop (test_visibility.TestVisibility) ... ok
testShouldCountElementsAsVisibleIfStylePropertyHasBeenSet (test_visibility.TestVisibility) ... ok
testShouldModifyTheVisibilityOfAnElementDynamically (test_visibility.TestVisibility) ... ok
testShouldSayElementIsInvisibleWhenOverflowXIsHiddenAndOutOfViewport (test_visibility.TestVisibility) ... ok
testShouldSayElementIsVisibleWhenItHasNegativeTransformButElementisntInANegativeSpace (test_visibility.TestVisibility) ... ok
testShouldSayElementWithZeroTransformIsVisible (test_visibility.TestVisibility) ... ok
testShouldSayElementsWithNegativeTransformAreNotDisplayed (test_visibility.TestVisibility) ... ok
testShouldSayElementsWithParentWithNegativeTransformAreNotDisplayed (test_visibility.TestVisibility) ... ok
testShouldShowElementNotVisibleWhenParentElementHasHiddenAttribute (test_visibility.TestVisibility) ... ok
testShouldShowElementNotVisibleWithHiddenAttribute (test_visibility.TestVisibility) ... ok
testVisibilityShouldTakeIntoAccountParentVisibility (test_visibility.TestVisibility) ... ok

----------------------------------------------------------------------
Ran 16 tests in 3.128s

OK
TEST-START test_window_management.py
testShouldCauseAWindowToLoadAndCheckItIsOpenThenCloseIt (test_window_management.TestSwitchWindow) ... ok
testShouldLoadAWindowAndThenCloseIt (test_window_management.TestSwitchWindow) ... ok
test_windows (test_window_management.TestSwitchWindow) ... ok

----------------------------------------------------------------------
Ran 3 tests in 0.929s

OK
TEST-START test_appcache.py
testWeCanGetTheStatusOfTheAppCache (test_appcache.AppCacheTests) ... ok

----------------------------------------------------------------------
Ran 1 test in 0.180s

OK
TEST-START test_screenshot.py
testWeCanTakeAScreenShotEntireCanvas (test_screenshot.ScreenshotTests) ... ok
testWeCanTakeAScreenShotOfAnElement (test_screenshot.ScreenshotTests) ... ok
testWeCanTakeAScreenShotWithHighlightOfAnElement (test_screenshot.ScreenshotTests) ... ok

----------------------------------------------------------------------
Ran 3 tests in 0.692s

OK
TEST-START test_cookies.py
testAddCookie (test_cookies.CookieTest) ... ok
testAddingACookieThatExpiredInThePast (test_cookies.CookieTest) ... ok
testDeleteAllCookie (test_cookies.CookieTest) ... foo=bar
ok
testDeleteCookie (test_cookies.CookieTest) ... ok
testGetAllCookies (test_cookies.CookieTest) ... ok
testShouldGetCookieByName (test_cookies.CookieTest) ... ok
testShouldNotDeleteCookiesWithASimilarName (test_cookies.CookieTest) ... ok

----------------------------------------------------------------------
Ran 7 tests in 1.410s

OK
TEST-START test_window_title.py
test_get_html_title (test_window_title.TestTitle) ... ok
test_get_chrome_title (test_window_title.TestTitleChrome) ... ok

----------------------------------------------------------------------
Ran 2 tests in 0.282s

OK
TEST-START test_window_type.py
test_get_window_type (test_window_type.TestWindowTypeChrome) ... ok

----------------------------------------------------------------------
Ran 1 test in 0.105s

OK
TEST-START test_implicit_waits.py
testShouldImplicitlyWaitForASingleElement (test_implicit_waits.TestImplicitWaits) ... ok
testShouldStillFailToFindAnElementWhenImplicitWaitsAreEnabled (test_implicit_waits.TestImplicitWaits) ... ok

----------------------------------------------------------------------
Ran 2 tests in 4.399s

OK
TEST-START test_date_time_value.py
test_set_date (test_date_time_value.TestDateTime) ... ok
test_set_time (test_date_time_value.TestDateTime) ... ok

----------------------------------------------------------------------
Ran 2 tests in 0.384s

OK
TEST-START test_getactiveframe_oop.py
test_active_frame_oop (test_getactiveframe_oop.TestGetActiveFrameOOP) ... ok

----------------------------------------------------------------------
Ran 1 test in 0.826s

OK
TEST-START test_submit.py
test_should_be_able_to_submit_forms (test_submit.TestSubmit) ... FAIL
test_should_submit_a_form_when_any_element_wihin_that_form_is_submitted (test_submit.TestSubmit) ... ok
test_should_submit_a_form_when_any_input_element_within_that_form_is_submitted (test_submit.TestSubmit) ... ok

======================================================================
FAIL: None
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/dburns/development/mozilla/mozilla-inbound/testing/marionette/client/marionette/marionette_test.py", line 132, in run
    testMethod()
  File "/Users/dburns/development/mozilla/mozilla-inbound/testing/marionette/client/marionette/tests/unit/test_submit.py", line 17, in test_should_be_able_to_submit_forms
    self.assertTrue(False)
TEST-UNEXPECTED-FAIL | test_submit.py test_submit.TestSubmit.test_should_be_able_to_submit_forms | AssertionError: False is not true
----------------------------------------------------------------------
Ran 3 tests in 1.754s

FAILED (failures=1)

SUMMARY
-------
passed: 183
failed: 1
todo: 0

FAILED TESTS
-------
test_submit.py test_submit.TestSubmit.test_should_be_able_to_submit_forms
had similiar output for ./mach marionette-test

I forgot to mention in my previous comment I made a test fail on purpose
I can reproduce this; it isn't a Marionette problem per se, but some interaction between Marionette and gaiatest.  Thus, it isn't reproducible unless you run a test via gaiatest:

starting httpd
running webserver on http://192.168.126.181:42327/
TEST-START test_kill.py
test_kill (test_kill.TestKill) ... FAIL
test_kill_multiple (test_kill.TestKill) ... ok

----------------------------------------------------------------------
Ran 2 tests in 8.495s

OK

SUMMARY
-------
passed: 1
failed: 0
todo: 0
This _is_ caused by the moztest integration.
Assignee: nobody → jgriffin
Comment on attachment 818066 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12902

This fixes the HTML reports also, which were broken as well.  The duration of tests is not showing up correctly in these reports (it's always 0).  That fix will require a change to core Marionette and another push to pypi, so I'll save that for a separate bug.
Attachment #818066 - Flags: review?(dave.hunt)
Depends on: 879900
Depends on: 927606
Blocks: 927391
Comment on attachment 818066 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12902

As dave is on PTO I reviewed this, it is not showing full traceback in the report. See the PR for more info!
Attachment #818066 - Flags: review?(dave.hunt) → review-
Comment on attachment 818066 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12902

PR updated; the stack traces now show up correctly.
Attachment #818066 - Flags: review- → review?(zcampbell)
Comment on attachment 818066 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12902

r+ from me but I'd prefer dave to look at it if you think it needs it as I can't speak for the code, only for what I see in the console/html report.
Attachment #818066 - Flags: review?(zcampbell) → review+
Comment on attachment 818066 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12902

Ok, if you don't need it urgently, we'll wait for davehunt's review tomorrow.
Attachment #818066 - Flags: review?(dave.hunt)
Comment on attachment 818066 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12902

I don't think we need to gather debug on an unexpected success. Also, I think it would be good to separate out the items in debug now that we can. I'm happy for this to be done in a separate bug though. r=me with the change for unexpected success.
Attachment #818066 - Flags: review?(dave.hunt) → review+
(In reply to Jonathan Griffin (:jgriffin) from comment #7)
> This fixes the HTML reports also, which were broken as well.  The duration
> of tests is not showing up correctly in these reports (it's always 0).  That
> fix will require a change to core Marionette and another push to pypi, so
> I'll save that for a separate bug.

Has this been raised?
(In reply to Dave Hunt (:davehunt) from comment #13)
> (In reply to Jonathan Griffin (:jgriffin) from comment #7)
> > This fixes the HTML reports also, which were broken as well.  The duration
> > of tests is not showing up correctly in these reports (it's always 0).  That
> > fix will require a change to core Marionette and another push to pypi, so
> > I'll save that for a separate bug.
> 
> Has this been raised?

Nevermind, Zac pointed me to bug 927606.
I removed the gather_debug from unexpectedSuccesses.  merged: https://github.com/mozilla-b2g/gaia/commit/d0861c2913a57cb681ec4cd4d52d73cc0f479ac9
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Ah, bug 928635, and I should have been asking something more like "did you realize that we were persistently hitting and failing to report multiple errors in gaia-ui-test, so that landing this would mean closing b2g-inbound until they are found and filed and fixed?"
No, I didn't realize that, my apologies!
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.