Make collections API use ElasticSearch for apps inside a collection

VERIFIED FIXED in 2013-10-28

Status

P2
normal
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: mat, Assigned: mat)

Tracking

2013-10-28
Points:
---
Dependency tree / graph

Details

(Whiteboard: [qa+])

(Assignee)

Description

5 years ago
Collections API should use ElasticSearch to return the list of apps inside a Collection. This would get us feature profiling and region exclusions without killing performance.

Collections themselves would still be returned using SQL queries.
(Assignee)

Updated

5 years ago
Assignee: nobody → mpillard
Assignee: mpillard → charmston
Assignee: charmston → mpillard
(Assignee)

Updated

5 years ago
Status: NEW → ASSIGNED
Target Milestone: --- → 2013-10-28
(Assignee)

Comment 1

5 years ago
Fixed in https://github.com/mozilla/zamboni/commit/6f758bb02f93f13f8bed2406fb7f3b69509caec2

This is a behind a waffle switch called 'collections-use-es-for-apps', and only enabled for search/featured/ endpoint. The waffle switch defaults to 'off'.


STR:
- Test adding/deleting/re-ordering apps in collections in the curation tool
- Test that the apps are correctly shown for the operator shelf/featured apps in consumer pages.

Note: make sure to test with the waffle switch 'collections-use-es-for-apps' on and off.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [qa-]
(Assignee)

Updated

5 years ago
Whiteboard: [qa-]
(Assignee)

Comment 2

5 years ago
On -dev, trying to load api/v1/fireplace/search/featured/&cat=&lang=fr&region=worldwide:

With the switch disabled:

Percentage of the requests served within a certain time (ms)
  50%   2679
  66%   2691
  75%   2716
  80%   2890
  90%   3336
  95%   3336
  98%   3336
  99%   3336
 100%   3336 (longest request)

With the switch enabled:

Percentage of the requests served within a certain time (ms)
  50%   1652
  66%   1665
  75%   1668
  80%   1739
  90%   1795
  95%   1795
  98%   1795
  99%   1795
 100%   1795 (longest request)
Amazing improvements. Great work, Mathieu!
Whiteboard: [qa+]
(Assignee)

Updated

5 years ago
Blocks: 926640

Comment 4

5 years ago
Verified as fixed with the waffle switch off and on.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.