927428 - use __LP64__ instead of HAVE_64BIT_OS in the linker

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: use __LP64__ instead of HAVE_64BIT_OS in the linker

I think we could dispense with the __SIZEOF_POINTER__ check, too?

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 817863 [details] [diff] [review]
use __LP64__ instead of HAVE_64BIT_OS in the linker

Review of attachment 817863 [details] [diff] [review]:
-----------------------------------------------------------------

::: mozglue/linker/Logging.h
@@ +67,5 @@
>        LOG(__VA_ARGS__);  \
>      }                    \
>    } while(0)
>  
> +#if defined(__LP64__) || __SIZEOF_POINTER__ == 8

You can remove the __SIZEOF_POINTER__ check, yes.

Comment 3

[Nathan Froyd [:froydnj]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/09fcb0805831

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/09fcb0805831