use __LP64__ instead of HAVE_64BIT_OS in the linker

RESOLVED FIXED in mozilla27

Status

()

Product:
Core
Component:
XPCOM
Type:
defect
Status:
RESOLVED FIXED
Opened:
6 years ago
Updated:
6 years ago

People

(Reporter: froydnj, Unassigned)

Tracking

(Blocks 1 bug)

Version:
unspecified
Target:
mozilla27
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

use __LP64__ instead of HAVE_64BIT_OS in the linker
1.41 KB, patch
glandium
: review+
Details | Diff | Splinter Review 
No description provided.
I think we could dispense with the __SIZEOF_POINTER__ check, too?
Attachment #817863 - Flags: review?(mh+mozilla)
Comment on attachment 817863 [details] [diff] [review]
use __LP64__ instead of HAVE_64BIT_OS in the linker

Review of attachment 817863 [details] [diff] [review]:
-----------------------------------------------------------------

::: mozglue/linker/Logging.h
@@ +67,5 @@
>        LOG(__VA_ARGS__);  \
>      }                    \
>    } while(0)
>  
> +#if defined(__LP64__) || __SIZEOF_POINTER__ == 8

You can remove the __SIZEOF_POINTER__ check, yes.
Attachment #817863 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/09fcb0805831
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.