Status
()
People
(Reporter: froydnj, Unassigned)
Tracking
(Blocks: 1 bug)
Firefox Tracking Flags
(Not tracked)
Details
Attachments
(1 attachment)
|
1.41 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
| Comment hidden (empty) |
|
(Reporter) | |
Comment 1•5 years ago
|
||
Created attachment 817863 [details] [diff] [review] use __LP64__ instead of HAVE_64BIT_OS in the linker I think we could dispense with the __SIZEOF_POINTER__ check, too?
Attachment #817863 -
Flags: review?(mh+mozilla)
|
||
Comment 2•5 years ago
|
||
Comment on attachment 817863 [details] [diff] [review] use __LP64__ instead of HAVE_64BIT_OS in the linker Review of attachment 817863 [details] [diff] [review]: ----------------------------------------------------------------- ::: mozglue/linker/Logging.h @@ +67,5 @@ > LOG(__VA_ARGS__); \ > } \ > } while(0) > > +#if defined(__LP64__) || __SIZEOF_POINTER__ == 8 You can remove the __SIZEOF_POINTER__ check, yes.
Attachment #817863 -
Flags: review?(mh+mozilla) → review+
|
|
(Reporter) | |
Comment 3•5 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/09fcb0805831
Flags: in-testsuite-
|
||
Comment 4•5 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/09fcb0805831
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in
before you can comment on or make changes to this bug.