927432 - Failed to run chrome MarionetteJSTestCase with finish() called in some function, error: finish() not called

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Vicamo Yang [:vicamo][:vyang]]

In marionette-server.js, on receiving an 'executeJSScript' request, it's supposed to call |this.executeWithCallback| but actually |this.execute| is called.  The line

  if (aRequest.async) {

should really be:

  if (aRequest.parameters.async) {

Comment 1

[Vicamo Yang [:vicamo][:vyang]]

Attachment: test_chrome_async_finish.js

Example test script to trigger this bug.

Comment 2

[Vicamo Yang [:vicamo][:vyang]]

Attachment: patch

Proposed patch. Full try: https://tbpl.mozilla.org/?tree=Try&rev=d76ff3e1983b

Comment 3

[Jonathan Griffin (:jgriffin)]

Comment on attachment 817897 [details] [diff] [review]
patch

Review of attachment 817897 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks vicamo.

Comment 4

[Vicamo Yang [:vicamo][:vyang]]

https://hg.mozilla.org/integration/b2g-inbound/rev/ea748c15da80

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ea748c15da80

Comment 6

[Michael Vines [:m1] [:evilmachines]]

(uplift please, this fixes all our broken tests)

Comment 7

[Michael Vines [:m1] [:evilmachines]]

Is there a flag that this bug is missing preventing it from showing up in the "needs an uplift to v1.2" queue?

Comment 8

[Ed Morley [:emorley]]

RyanVM has been PTO since 21st (until 28th).

I'm clearing some of the backlog now.

Comment 9

[Ed Morley [:emorley]]

remote:   https://hg.mozilla.org/releases/mozilla-aurora/rev/f8a6be5f607d