Closed Bug 927432 Opened 6 years ago Closed 6 years ago

Failed to run chrome MarionetteJSTestCase with finish() called in some function, error: finish() not called

Categories

(Testing :: Marionette, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(blocking-b2g:koi+, firefox26 fixed, firefox27 fixed, b2g-v1.2 fixed)

RESOLVED FIXED
mozilla27
blocking-b2g koi+
Tracking Status
firefox26 --- fixed
firefox27 --- fixed
b2g-v1.2 --- fixed

People

(Reporter: vicamo, Assigned: vicamo)

References

Details

Attachments

(2 files)

In marionette-server.js, on receiving an 'executeJSScript' request, it's supposed to call |this.executeWithCallback| but actually |this.execute| is called.  The line

  if (aRequest.async) {

should really be:

  if (aRequest.parameters.async) {
Example test script to trigger this bug.
Attached patch patchSplinter Review
Proposed patch. Full try: https://tbpl.mozilla.org/?tree=Try&rev=d76ff3e1983b
Attachment #817897 - Flags: review?(dburns)
Comment on attachment 817897 [details] [diff] [review]
patch

Review of attachment 817897 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks vicamo.
Attachment #817897 - Flags: review?(dburns) → review+
Blocks: 926302
https://hg.mozilla.org/mozilla-central/rev/ea748c15da80
Assignee: nobody → vyang
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
(uplift please, this fixes all our broken tests)
blocking-b2g: --- → koi+
Is there a flag that this bug is missing preventing it from showing up in the "needs an uplift to v1.2" queue?
Flags: needinfo?(ryanvm)
Flags: needinfo?(cbook)
Flags: needinfo?(emorley)
RyanVM has been PTO since 21st (until 28th).

I'm clearing some of the backlog now.
Flags: needinfo?(ryanvm)
Flags: needinfo?(cbook)
You need to log in before you can comment on or make changes to this bug.