927459 - [DBus] Cleanup DBusThread

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Thomas Zimmermann [:tzimmermann] [:tdz]]

DBusThread is actually not a thread, but  a connection to the DBus service. And it doesn't really handle connections, but mostly polls file descriptors.

The name should be changed into something more meaning full, such as DBusWatcher; and the functions for handling DBusWatch structures should be converted to methods of DBusWatcher.

Comment 1

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [01] Bug 927459: Cleanup DBusThread

Comment 2

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [01] Bug 927459: Cleanup DBusThread

Comment 3

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [02] Bug 927459: Move poll functionality to DBusWatcher

Comment 4

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [03] Bug 927459: Add DBusWatcher::Stop

Comment 5

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [04] Bug 927459: Move helpers to DBusWatcher

Comment 6

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [05] Bug 927859: Cleanup DBus thread after DBusWatcher

Comment 7

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Thank you!

https://hg.mozilla.org/integration/b2g-inbound/rev/4c70ede8a5f8
https://hg.mozilla.org/integration/b2g-inbound/rev/c74585ee57e5
https://hg.mozilla.org/integration/b2g-inbound/rev/83060920aaf5
https://hg.mozilla.org/integration/b2g-inbound/rev/6921551afb42
https://hg.mozilla.org/integration/b2g-inbound/rev/ac3b5c47d520

https://tbpl.mozilla.org/?tree=B2g-Inbound&rev=ac3b5c47d520

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/4c70ede8a5f8
https://hg.mozilla.org/mozilla-central/rev/c74585ee57e5
https://hg.mozilla.org/mozilla-central/rev/83060920aaf5
https://hg.mozilla.org/mozilla-central/rev/6921551afb42

Comment 9

[Ed Morley [:emorley]]

had wrong bug #:
https://hg.mozilla.org/mozilla-central/rev/ac3b5c47d520