927465 - Change SystemMessageManager:Message weak listener for an strong one

Status: RESOLVED WONTFIX

(Core :: DOM: Core & HTML, defect)

Description

[Fernando Jiménez Moreno [:ferjm]]

See https://bugzilla.mozilla.org/show_bug.cgi?id=927363#c2

Comment 1

[Fernando Jiménez Moreno [:ferjm]]

Attachment: v1

I should have wait before pushing Bug 927363 :\... sorry about that.

Comment 2

[Gene Lian (I already quit Mozilla)]

Regarding the original Bug 927363 you've done, I still the same concern about it. You did: 

  this.addMessageListeners("SystemMessageManager:GetPendingMessages:Return");

by adding it as a weak reference. It'd have the same issue that the listener can be removed at any time points before the message is returned.

I have a feeling that adding listeners as weak ones by default is very dangerous when Justin changed everything to be weak referenced in the first place. Default should be strong referenced unless it has to be added as weak referenced.

Comment 3

[Fernando Jiménez Moreno [:ferjm]]

Actually, I have to agree with you. I've talked with Fabrice about this and we both agree that we should get back to strong listeners by default. I think we can handle the original issue of leaked WebApps objects (bug 889984) that started all this weak vs strong listeners pain in a different way, as suggested in https://bugzilla.mozilla.org/show_bug.cgi?id=903291#c32 We can still also add weak listeners where we consider it mandatory.

I'm closing this as WONTFIX and opening a new bug to default to strong listeners.

Thanks Gene.

Comment 4

[Gene Lian (I already quit Mozilla)]

(In reply to Fernando Jiménez Moreno [:ferjm] from comment #3)
> I'm closing this as WONTFIX and opening a new bug to default to strong
> listeners.

Thank Fernando! Btw, what's the bug number?

Comment 5

[Gene Lian (I already quit Mozilla)]

OK. I saw it. Thanks!