927469 - [traceback] When saving manifest URL: AttributeError: 'tuple' object has no attribute 'get'

Status: VERIFIED FIXED

(Marketplace Graveyard :: Developer Pages, defect, P2)

Description

[Kumar McMillan [:kumar]]

STR: As an admin, edit the manifest URL for an app and click save.

on stage: http://sentry.dmz.phx1.mozilla.com/addons/marketplace-stage/group/16920/

AttributeError: 'tuple' object has no attribute 'get'

Stacktrace (most recent call last):

  File "django/core/handlers/base.py", line 111, in get_response
    response = callback(request, *callback_args, **callback_kwargs)
  File "newrelic/api/object_wrapper.py", line 216, in __call__
    self._nr_instance, args, kwargs)
  File "newrelic/hooks/framework_django.py", line 475, in wrapper
    return wrapped(*args, **kwargs)
  File "amo/decorators.py", line 157, in wrapper
    return f(*args, **kw)
  File "amo/decorators.py", line 149, in wrapper
    return f(*args, **kw)
  File "python2.6/contextlib.py", line 34, in __exit__
    self.gen.throw(type, value, traceback)
  File "amo/models.py", line 38, in skip_cache
    yield
  File "amo/decorators.py", line 149, in wrapper
    return f(*args, **kw)
  File "addons/decorators.py", line 33, in wrapper
    return f(request, addon, *args, **kw)
  File "amo/decorators.py", line 32, in wrapper
    return func(request, *args, **kw)
  File "mkt/developers/decorators.py", line 49, in wrapper
    return fun()
  File "mkt/developers/decorators.py", line 28, in <lambda>
    *args, **kw)
  File "mkt/developers/views.py", line 487, in refresh_manifest
    _update_manifest(addon_id, True, ())
  File "mkt/webapps/tasks.py", line 134, in _update_manifest
    failed_fetches[id] = failed_fetches.get(id, 0) + 1


Also, this may or may not be related: http://sentry.dmz.phx1.mozilla.com/addons/marketplace-stage/group/16828/

Comment 2

[Mathieu Pillard [:mat]]

Re-opening, this is actually a different issue from bug 927179, through both are very strange.

Comment 3

[Mathieu Pillard [:mat]]

Fixed in https://github.com/mozilla/zamboni/commit/de34e38264a786601a5f42672e0ff88456bc5203

Comment 4

[krupa raj[:krupa]]

verified fixed that editing the manifest doesn't traceback.

I changed the name and the change was updated. I'm not why it is a 204 but looks like it works.

POST https://marketplace.allizom.org/developers/app/pricepoint1-010/refresh_manifest [HTTP/1.1 204 NO CONTENT 1091ms]
22:39:25.680 POST https://marketplace.allizom.org/developers/app/pricepoint1-010/refresh_manifest [HTTP/1.1 204 NO CONTENT 1086ms]