927476 - Robocop pixel tests fail consistently on Android x86 emulator and many devices

Status: RESOLVED FIXED

(Firefox for Android :: General, defect)

Description

[Geoff Brown [:gbrown]]

+++ This bug was initially created as a clone of Bug #898036 +++

The Robocop pixel tests -- testLoad, testAxisLocking, etc -- fail consistently when run on the x86 emulator. They also fail locally when run on a Motorola Razr i (XT890) or Galaxy S.

Running locally, the screen looks the same as it did in bug 898036 before we added pref layout.css.devPixelsPerPx="1.0".

It looks to me like that pref is still defined. I wonder if this might have been regressed by bug 912166.

Comment 1

[Geoff Brown [:gbrown]]

It appears this was not regressed by bug 912166.

Debugging suggests that the test harness is setting the pref, but not setting it correctly.

Comment 2

[Geoff Brown [:gbrown]]

Bug 746243 updated the way extra preferences are handled. As a side-effect, the quoting that was previously needed for this pref is no longer necessary, so the pref value is set to "1.0" instead of 1.0.

Comment 3

[Geoff Brown [:gbrown]]

If I remove the extra quotes for devPixelsPerPx, pixel tests pass and the prefs passed to mozprofile are:

{
u'dom.max_chrome_script_run_time': 0, 
u'media.webaudio.legacy.AudioContext': True, 
u'dom.forms.color': True, 
u'extensions.getAddons.get.url': u'http://192.168.0.50:8888/extensions-dummy/repositoryGetURL',
u'javascript.options.showInConsole': True, 
u'app.update.enabled': False, 
u'security.default_personal_cert': u'Select Automatically', 
u'font.size.inflation.emPerLine': 0, 
u'urlclassifier.updateinterval': 172800, 
u'media.webaudio.enabled': True, 
u'dom.min_background_timeout_value': 1000, 
u'extensions.update.url': u'http://192.168.0.50:8888/extensions-dummy/updateURL', 
u'network.http.prompt-temp-redirect': False, 
u'dom.forms.number': True, 
u'geo.provider.testing': True, 
u'dom.send_after_paint_to_content': True, u'security.turn_off_all_security_so_that_viruses_can_take_over_this_computer': True,
u'dom.experimental_forms': True, 
u'dom.allow_scripts_to_close_windows': True, 
u'media.webaudio.legacy.PannerNode': True, 
u'dom.popup_maximum': -1, 
u'media.webaudio.legacy.AudioParam': True, 
u'test.mousescroll': True, 
u'layout.css.report_errors': True, 
u'browser.EULA.override': True, 
u'browser.firstrun.show.localepicker': False, 
u'dom.undo_manager.enabled': True, 
u'network.http.bypass-cachelock-threshold': 200000, 
u'devtools.debugger.remote-port': 6023, 
u'browser.console.showInPanel': True, 
u'font.size.inflation.minTwips': 0, 
u'layout.css.devPixelsPerPx': u'1.0', 
u'toolkit.telemetry.notifiedOptOut': 999, 
u'dom.gamepad.non_standard_events.enabled': True, 
u'media.webaudio.legacy.AudioBufferSourceNode': True, 
u'geo.wifi.uri': u'http://192.168.0.50:8888/tests/dom/tests/mochitest/geolocation/network_geolocation.sjs', 
u'extensions.getAddons.search.url': u'http://192.168.0.50:8888/extensions-dummy/repositorySearchURL',
u'extensions.getAddons.maxResults': 0, 
u'browser.download.panel.shown': True, 
u'datareporting.healthreport.documentServerURI': u'http://192.168.0.50:8888/healthreport/',
u'javascript.options.jit_hardening': True, 
u'toolkit.telemetry.prompted': 999, 
u'browser.ui.layout.tablet': 0, 
u'dom.w3c_touch_events.enabled': 1, 
u'plugins.update.url': u'http://192.168.0.50:8888/plugins-dummy/updateCheckURL', 
u'extensions.installDistroAddons': False, 
u'media.webaudio.legacy.OscillatorNode': True, 
u'extensions.update.enabled': False, 
u'browser.safebrowsing.keyURL': u'http://192.168.0.50:8888/safebrowsing-dummy/newkey', 
u'browser.pagethumbnails.capturing_disabled': True, 
u'shell.checkDefaultClient': False,
u'robocop.logfile': u'"/mnt/sdcard/tests/robocop.log"', 
u'extensions.getAddons.cache.enabled': False, 
u'browser.startup.page': 0, 
u'network.activity.blipIntervalMilliseconds': 250, 
u'dom.global-constructor.disable.mozContact': False, 
u'extensions.hotfix.url': u'http://192.168.0.50:8888/extensions-dummy/hotfixURL', u'app.update.staging.enabled': False, 
u'dom.navigator-property.disable.mozContacts': False, 
u'accessibility.typeaheadfind.autostart': False, 
u'browser.dom.window.dump.enabled': True, 
u'browser.chrome.dynamictoolbar': False, 
u'dom.mozSettings.enabled': True, 
u'dom.gamepad.enabled': True, 
u'media.cache_size': 100, 
u'signed.applets.codebase_principal_support': True, 
u'gfx.color_management.force_srgb': True, 
u'browser.search.suggest.prompted': True, 
u'dom.use_xbl_scopes_for_remote_xul': True, 
u'media.webaudio.legacy.BiquadFilterNode': True, 
u'browser.firstrun.show.uidiscovery': False, 
u'extensions.enabledScopes': 5, 
u'dom.webcomponents.enabled': True, 
u'dom.successive_dialog_time_limit': 0, 
u'extensions.update.background.url': u'http://192.168.0.50:8888/extensions-dummy/updateBackgroundURL', 
u'layout.debug.enable_data_xbl': True, 
u'extensions.blocklist.url': u'http://192.168.0.50:8888/extensions-dummy/blocklistURL', 
u'browser.safebrowsing.gethashURL': u'http://192.168.0.50:8888/safebrowsing-dummy/gethash', 
u'datareporting.policy.dataSubmissionPolicyBypassAcceptance': True, 
u'security.notification_enable_delay': 0, 
u'browser.panorama.experienced_first_run': True, 
u'geo.wifi.testing': True, 
u'dom.max_script_run_time': 0, 
u'devtools.errorconsole.enabled': True, 
u'security.warn_viewing_mixed': False, 
u'media.volume_scale': u'0.01', 
u'dom.disable_open_during_load': False, 
u'extensions.getAddons.search.browseURL': u'http://192.168.0.50:8888/extensions-dummy/repositoryBrowseURL', 
u'camino.warn_when_closing': False, 
u'extensions.getAddons.getWithPerformance.url': u'http://192.168.0.50:8888/extensions-dummy/repositoryGetWithPerformanceURL', 
u'hangmonitor.timeout': 0, 
u'browser.search.suggest.enabled': True, 
u'network.manage-offline-status': False, 
u'dom.mozContacts.enabled': True, 
u'browser.shell.checkDefaultBrowser': False, 
u'browser.warnOnQuit': False, 
u'geo.wifi.logging.enabled': True, 
u'browser.safebrowsing.updateURL': u'http://192.168.0.50:8888/safebrowsing-dummy/update', 
u'extensions.webservice.discoverURL': u'http://192.168.0.50:8888/extensions-dummy/discoveryURL'
}

This one still doesn't look right:

u'robocop.logfile': u'"/mnt/sdcard/tests/robocop.log"', 

I'll look into that too.

Comment 4

[Geoff Brown [:gbrown]]

Attachment: Remove extra pref quoting

Pref robocop.logfile is never used (we write "logfile=..." into robotium.config instead) -- so I removed that pref completely.

Comment 5

[Joel Maher ( :jmaher ) (UTC-4)]

Comment on attachment 820526 [details] [diff] [review]
Remove extra pref quoting

Review of attachment 820526 [details] [diff] [review]:
-----------------------------------------------------------------

simple cleanup!

Comment 6

[Geoff Brown [:gbrown]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/270f7e1b1cf2

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/270f7e1b1cf2