mozharness clobberer should retry

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: catlee, Assigned: ffledgling)

Tracking

({sheriffing-untriaged})

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [simple][mozharness])

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Sometimes we can't contact the clobberer service for various reasons. We should retry a few times before giving up.

This probably means wrapping this code in a loop:
http://hg.mozilla.org/build/mozharness/file/283c75b9580f/mozharness/mozilla/purge.py#l101
Keywords: sheriffing-untriaged
(Assignee)

Comment 1

5 years ago
Created attachment 819049 [details] [diff] [review]
Bug927525.patch

Patch adds retry.
using mozharness.base.script's retry ,instead of a loop, as per aki's suggestion.

catlee can you please look at this and tell me if this is okay, or if any kind of changes are required? Thanks!
Assignee: nobody → ffledgling
Attachment #819049 - Flags: feedback?(catlee)
(Reporter)

Comment 2

5 years ago
Comment on attachment 819049 [details] [diff] [review]
Bug927525.patch

Review of attachment 819049 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, thanks!
Attachment #819049 - Flags: feedback?(catlee) → feedback+
merged to production mozharness
(Assignee)

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Component: General Automation → Mozharness
You need to log in before you can comment on or make changes to this bug.