927588 - [clock] Timer - Remove seconds from timer

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Clock, defect)

Description

[Rob MacDonald [:robmac]]

As per conversation with Bocoup, please remove the seconds from the timer feature. For the latest version of the Timer spec, please see https://mozilla.box.com/s/xy4z7ny19aulo9urpwmo.

Comment 1

[Dylan Oliver [:doliver]]

triage: in a joint meeting with product/ux/dev, we agreed that this was critical functionality for launching this feature in 1.2.

Comment 2

[Eric O'Connor [:oconnore]]

Reassigning since Adam has a branch that addresses this: https://github.com/Protonk/gaia/tree/timerux

Comment 3

[Adam Hyland [:protonk]]

I'll add a PR which resolves this issue shortly by hiding seconds for the timer while the remaining time is > 1 hour and displaying them where the remaining time is < 1 hour. I feel this resolves the principal issue: seconds seem too insignificant to display when the most significant unit is 3600 seconds long while making the timer still meaningful for short durations (e.g. boiling an egg: we want the phone to update the time left more than once every 60 seconds). 

I'd like some feedback from UX on this as the original direction was to have the seconds removed entirely.

Comment 4

[Rob MacDonald [:robmac]]

Hi Adam...

I should clarify. What I actually meant by removing the seconds was in setting the timer as opposed to actually displaying the remaining time. In the case of the elapsed time, do include the seconds. 

Does this make sense? Again, sorry for the confusion!

- Rob

Comment 5

[Adam Hyland [:protonk]]

Attachment: Github Pull Request

Per the comments from from Scott, I've updated the PR to display elapsed seconds but disable the seconds in the picker.

Comment 6

[Adam Hyland [:protonk]]

Err, it was Rob, not Scott. Sorry!

Yes, this makes things much more clear. Thank you.
(In reply to Rob MacDonald [:robmac] from comment #4)
> Hi Adam...
> 
> I should clarify. What I actually meant by removing the seconds was in
> setting the timer as opposed to actually displaying the remaining time. In
> the case of the elapsed time, do include the seconds. 
> 
> Does this make sense? Again, sorry for the confusion!
> 
> - Rob

Comment 7

[Mike Pennisi [:jugglinmike]]

Comment on attachment 823667 [details] [review]
Github Pull Request

Hey there Adam,

Before we land this, we'll need to remove the (now empty) column for the "second" entry. Also, the latest visual specification defines text labels at the top of each spinner element (don't forget to add new L10n keys for "Hours" and "Minutes"). Finally: can you think of a non-intrusive way to back these changes with tests?

Comment 8

[Jason Smith [:jsmith]]

Renoming for more discussion - this is not a must have feature for 1.2. If it isn't ready for 1.2 because we need this, then the feature needs to be preffed off for 1.2 and ride the trains to 1.3.

Comment 9

[Mike Pennisi [:jugglinmike]]

Comment on attachment 823667 [details] [review]
Github Pull Request

Hi Adam,

I left some feedback and a suggested unit test on the GitHub pull request.

Comment 10

[Preeti Raghunath(:Preeti)]

per triage moving to 1.3? This is to remove late l10n changes.

Comment 11

[Jason Smith [:jsmith]]

(In reply to Preeti Raghunath(:Preeti) from comment #10)
> per triage moving to 1.3? This is to remove late l10n changes.

Later discussion - leaving this koi? for tomorrow's discussion.

Comment 12

[Mike Pennisi [:jugglinmike]]

Comment on attachment 823667 [details] [review]
Github Pull Request

Looking good, Adam!

Comment 13

[Mike Pennisi [:jugglinmike]]

master: https://github.com/mozilla-b2g/gaia/commit/23cf2c26cd662ce91dc7e7ca102faaeb544b7ea6

Thanks, Adam!

Comment 14

[Jason Smith [:jsmith]]

Discussed offline - UX has indicated they are fine with the implementation for uplift, so I'm setting this back to koi+.

Comment 15

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 23cf2c26cd662ce91dc7e7ca102faaeb544b7ea6 to:
v1.2: 976223b1c065c36e42423d475f0a5f4955d66a0b

Comment 16

[Peter Bylenga [:PBylenga]]

Verified Fixed: Timer now no longer has a Seconds reel during pick, Timer still shows seconds during remaining time show. Hour and Minute Picker Reels have been adjusted visually to account for the removed Seconds Reel. 

Environmental Variables
Device: Buri v1.2 COM RIL
Build ID: 20131105004003
Gecko: http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/3ba912717904
Gaia: be4ea00a50236b10eb0a03232a28ffd0048e0cb8
Platform Version: 26.0
RIL Version: 01.01.00.019.281 
Firmware Version: US_20131015

Comment 17

[Dietrich Ayala (:dietrich)]

See bug 997097 for adding seconds back in. We can't ship a product that doesn't support Aeropress coffee preparation.