927592 - modal dialog handling doesn't work if you start a session early

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Malini Das [:mdas] - Away, not checking bugmail]

Attachment: wait for document ready to attach listener, and only do so if we're in B2G

using the --restart option when running gaiatest exposed this issue in https://bugzilla.mozilla.org/show_bug.cgi?id=779284#c69.

Comment 1

[Malini Das [:mdas] - Away, not checking bugmail]

This patch has been tested against a device using the --restart option when running  https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/gaiatest/tests/functional/gallery/test_gallery_delete_image.py repeatedly, and it works as expected

Comment 2

[Jonathan Griffin (:jgriffin)]

Comment on attachment 818055 [details] [diff] [review]
wait for document ready to attach listener, and only do so if we're in B2G

Review of attachment 818055 [details] [diff] [review]:
-----------------------------------------------------------------

This code makes the mozbrowsershowmodalprompt B2G-specific.  r+ if that's what we want.

Comment 3

[Malini Das [:mdas] - Away, not checking bugmail]

Yeah, we don't need this code in normal Firefox builds, it should just be added for B2G builds.

landed in m-i:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9b1ab0fcde02

Comment 4

[Malini Das [:mdas] - Away, not checking bugmail]

this will have to be uplifted to aurora when it lands in m-c

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9b1ab0fcde02

Comment 6

[Malini Das [:mdas] - Away, not checking bugmail]

This is blocking testing in aurora.

Comment 7

[Malini Das [:mdas] - Away, not checking bugmail]

pushed to aurora;
https://hg.mozilla.org/releases/mozilla-aurora/rev/c23fabebe5b1