Closed Bug 927592 Opened 6 years ago Closed 6 years ago

modal dialog handling doesn't work if you start a session early

Categories

(Testing :: Marionette, defect)

x86
All
defect
Not set

Tracking

(firefox26 fixed, firefox27 fixed, b2g-v1.2 fixed)

RESOLVED FIXED
mozilla27
Tracking Status
firefox26 --- fixed
firefox27 --- fixed
b2g-v1.2 --- fixed

People

(Reporter: mdas, Assigned: mdas)

References

Details

Attachments

(1 file)

This patch has been tested against a device using the --restart option when running  https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/gaiatest/tests/functional/gallery/test_gallery_delete_image.py repeatedly, and it works as expected
Comment on attachment 818055 [details] [diff] [review]
wait for document ready to attach listener, and only do so if we're in B2G

Review of attachment 818055 [details] [diff] [review]:
-----------------------------------------------------------------

This code makes the mozbrowsershowmodalprompt B2G-specific.  r+ if that's what we want.
Attachment #818055 - Flags: review?(jgriffin) → review+
Yeah, we don't need this code in normal Firefox builds, it should just be added for B2G builds.

landed in m-i:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9b1ab0fcde02
this will have to be uplifted to aurora when it lands in m-c
https://hg.mozilla.org/mozilla-central/rev/9b1ab0fcde02
Assignee: nobody → mdas
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Blocks: 928864
Blocks: 923674
This is blocking testing in aurora.
Whiteboard: [checkin-needed-aurora]
pushed to aurora;
https://hg.mozilla.org/releases/mozilla-aurora/rev/c23fabebe5b1
Whiteboard: [checkin-needed-aurora]
You need to log in before you can comment on or make changes to this bug.