927635 - Copy official and unofficial branding files in multilocale.py

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia, defect)

Description

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: patch

Branding files aren't correctly picked up

Comment 1

[Staś Małolepszy :stas]

This bug results in errors like the following ones

/home/stas/moz/b2g/gaia/shared/locales/branding/unofficial/branding.ar.properties could not be found.
/home/stas/moz/b2g/gaia/shared/locales/branding/unofficial/branding.ar.properties could not be found.

Comment 2

[Axel Hecht [:Pike]]

Can you be more precise on what this bug is about?

I'm asking because we're not exposing official branding to l10n, but we do expose unofficial.

Comment 3

[Staś Małolepszy :stas]

The key lines in the patch are:

+                # copy official branding from en-US, not from source
+                copy_official_branding(target_dirname, filename, locale)
+                # localization files can only modify unofficial branding, 
+                # amend the path accordingly
+                target_dirname = os.path.join(target_dirname, 'unofficial')

Currently, we read all English files (say, settings.properties and branding.properties) and then overwrite the English translations in the gL10nData dict with another language, but this another language's branding files are not in shared/.

So everything works as expected for official branding, because we do want en-US there, but it doesn't work for unofficial.

Also, if we ever switch the way we compose the translations dictionary (e.g. in L20n each locale is stored separately), we'll run into 404 errors.

Comment 4

[BMO Automation]

Firefox OS is not being worked on