927642 - Readd integration tests for notification lang/direction in gaia

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Due to some conflict issues between 915002 and 899574, lang/dir integration tests for 915002 got stomped. Readd tests.

Blocking because it should've been part of 915002, which blocked koi+.

Comment 1

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Attachment: Patch 1 (v1) - Add lang/dir integration tests for notifications

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Bug 915002
[User impact] if declined: Less testing
[Testing completed]: This IS tests.
[Risk to taking this patch] (and alternatives if risky): None
[String changes made]: None

Comment 2

[Gregor Wagner [:gwagner]]

Comment on attachment 818112 [details] [review]
Patch 1 (v1) - Add lang/dir integration tests for notifications

test-only. Doesn't need approval.

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/041bb1ec91ab

Comment 4

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Merge was accidental, Subsequently backed out

Comment 5

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 818112 [details] [review]
Patch 1 (v1) - Add lang/dir integration tests for notifications

Comment's on github. I don't think we are going to uplift Notification.get() (bug 899574) to 1.2, so these tests can't get uplifted either since they use that feature.

Comment 6

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Attachment: Patch 2 (v1) - Gaia v1.2 - Add lang/dir integration tests for notifications

Comment 7

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Attachment: Patch 1 (v2) - Add lang/dir integration tests for notifications

Updated to address review comments

Comment 8

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 819255 [details] [review]
Patch 1 (v2) - Add lang/dir integration tests for notifications

LGTM

Comment 9

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 819250 [details] [diff] [review]
Patch 2 (v1) - Gaia v1.2 - Add lang/dir integration tests for notifications

Review of attachment 819250 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

::: apps/system/test/marionette/notification_test.js
@@ +1,4 @@
>  var assert = require('assert'),
> +    NotificationTest = require('./lib/notification').NotificationTest,
> +    NotificationList = require('./lib/notification').NotificationList,
> +    Marionette = require('marionette-client'),

Nit: don't think we use this.

Comment 10

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Attachment: Patch 1 (v3) - Add lang/dir integration tests for notifications

Asking for rereview because this changed pretty massively.

Comment 11

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Attachment: Patch 1 (v4) - Add lang/dir integration tests for notifications

Fixed nits and optional argument issues.

Comment 12

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 824179 [details] [diff] [review]
Patch 1 (v4) - Add lang/dir integration tests for notifications

LGTM. Let's wait for Travis to go green and land.

Comment 13

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Patch 1 Landed to master

https://github.com/qdot/gaia/commit/ab40624fc6947b8cb7eed68bac09e6ecbdc285ef

Comment 15

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Attachment: Patch 2 (v2) - Gaia v1.2 - Add lang/dir integration tests for notifications

Rereview of the tests for v1.2. Only real difference between m-c and this is the persisting of the notification by hanging on wrappedJSObject.

Comment 16

[Michael Henretty [:mikehenrty][:mhenretty]]

v1.2: https://github.com/mozilla-b2g/gaia/commit/063a22e36a0641970176206e1ed3998202e14d37