927659 - [music][playback] Player should close files when paused

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Music, defect)

Description

[Dave Hylands [:dhylands]]

When the music player pauses, it should close the file being played, and reopen when the user clicks resume.

Currently, it keeps the file open, which has a side effect of causing the

Comment 1

[Dave Hylands [:dhylands]]

Bah. Continuing description.

Currently, it keeps the file open, which has a side effect of causing USB Mass Storage to detect the open file, which, in turn, prevents the sdcard from being shared with the PC.

Comment 2

[David Flanagan [:djf]]

I'd suggest that we probably only need to release the file when the we are both paused and not visible.  So if we're paused and get a mozvisiblilitychange event, release.  Or if we're hidden and we pause.

The video app does this so that it doesn't hold on to the hardware video decoder.

See bug 912609 and bug 922055 for an explanation of why this seems necessary.  I'm guessing that paused music will be a frustrating source of open files that the user can't figure out how to close.

Comment 3

[Hema Koka [:hema]]

We are adding a message to let the user know that there are open files (Bug 927961).

So, not blocking on this one for 1.2 (we can look into it for next release)

Comment 4

[Jim Porter (:squib)]

Do we still need this given that we're moving to MTP? I think leaving the file open while paused is technically correct from the perspective of physical media players, where "paused" and "stopped" are different. I don't feel super-strongly about this, though.

Comment 5

[BMO Automation]

Firefox OS is not being worked on