927666 - youtube wrapper's play pause cycle to force ready state stops buffering

Status: RESOLVED WONTFIX

(Webmaker Graveyard :: popcorn.js, defect)

Description

[Scott [:thecount] Downe]

STR:

1. get a youtube clip inside the gallery.
2. hit play on the main timeline.
3. add the clip.

Expected: it should play again after it's down buffering.
Actual: it'll keep buffering, or stop and not play, then if you play, it'll buffer. The buffer is never going to stop.

Might take a couple tries.

This is due to our play/pause hack to force ready state.

YouTube does not buffer it is paused, but, if we pause too soon in the play/pause hack, it'll never buffer, putting us in a broken state.

Proposal is to wait for getVideoLoadedFraction to change once.

Comment 1

[Scott [:thecount] Downe]

Attachment: https://github.com/mozilla/popcorn-js/pull/352

Comment 2

[Scott [:thecount] Downe]

Updated, I don't see this happening at home on linux.

Maybe some more testing is in order? Could be flash version or OS.

Comment 3

[Scott [:thecount] Downe]

I don't see this happening at home on windows, linux it's busted*

Comment 4

[Matthew Schranz [:mjschranz]]

Comment on attachment 818146 [details] [review]
https://github.com/mozilla/popcorn-js/pull/352

No luck reproducing the problem on Mac. Looks like for now we are going to leave this alone.

Comment 5

[Scott [:thecount] Downe]

I think this might of actually been caused by the loadedFraction changing as their duration changes from rounded to not rounded, which is why it was never very consistent.

Now with bug 928933 landed, I'm not able to hit this under extreme cases. Closing for now.