927667 - Search Suggestions RTL Support

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect, P2)

Description

[Niv Yahel]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:24.0) Gecko/20100101 Firefox/24.0 (Beta/Release)
Build ID: 20130910160258

Steps to reproduce:

I added RTL support for the search suggestions.

Comment 1

[Niv Yahel]

Attachment: searchEngineRow_rtl.patch

Comment 2

[Peter Retzer (:pretzer)]

Comment on attachment 818145 [details] [diff] [review]
searchEngineRow_rtl.patch

Sorry Niv, this seems to have fallen through the cracks. In the future you should make sure to request review from an actual person, so someone is responsible. You can find suggested reviewers when you upload an attachment by clicking the 'suggested reviewers' link.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 818145 [details] [diff] [review]
searchEngineRow_rtl.patch

Given the time since the patch was prepared, I am unsetting r? for now and will get this bug on the list of RTL bugs that need to be unbitrotted.

The patch itself looks simple and straightforward, but we need to get all the RTL code moving toward landing again.

Comment 4

[Itiel]

See bug 935388 comment 8 - these bugs are apparent also here in latest Nightly builds..

Plus, for some reason I can't see search suggestions from Google. It's simply blank. Are others experiencing the same issue?

Comment 5

[Rachelle Yang [:ryang][[e-mail]]]

Hi Max, 
would you mind checking these symptom ? 
Is it a RTL related issue ? Or we should file another big for this ?
Thank you very much.

Comment 6

[Khaled Hosny]

Attachment: Missing search suggestions

Same here, I see a Google icon in the search suggestions but no results are shown next to it.

Comment 7

[Max Liu [:maliu]]

Hi,

Is should be RTL related bug. I'll take it from here.

Comment 8

[Max Liu [:maliu]]

Attachment: Bug 927667 - [RTL] Align suggestion to end of icon,

Review commit: https://reviewboard.mozilla.org/r/98776/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/98776/

Comment 9

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8818839 [details]
Bug 927667 - [RTL] Align suggestion to end of icon,

https://reviewboard.mozilla.org/r/98776/#review99376

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/111b09bfa316
[RTL] Align suggestion to end of icon, r=sebastian

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/111b09bfa316

Comment 12

[Itiel]

I can confirm the latest Nightly builds fixes the search suggestions from Google issue, but this bug still depends on bug 1321633.
Reopening.

Comment 13

[Ioana Chiorean]

The suggestions work fine. 
The connected bug is fixed (partially as fading doesn't work on Arabic it seems but it is faded on RTL) 

Tested with AR Fennec 53.01 2017-01-17 with Pixel Android 7.1.1