Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Search Suggestions RTL Support

VERIFIED FIXED in Firefox 53

Status

()

Firefox for Android
Theme and Visual Design
P2
normal
VERIFIED FIXED
4 years ago
6 months ago

People

(Reporter: Niv Yahel, Assigned: maliu)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 53
Unspecified
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox53 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

4 years ago
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:24.0) Gecko/20100101 Firefox/24.0 (Beta/Release)
Build ID: 20130910160258

Steps to reproduce:

I added RTL support for the search suggestions.
(Reporter)

Comment 1

4 years ago
Created attachment 818145 [details] [diff] [review]
searchEngineRow_rtl.patch
Attachment #818145 - Flags: review?
(Reporter)

Updated

4 years ago
Blocks: 702845
(Reporter)

Updated

4 years ago
OS: Mac OS X → Android

Updated

4 years ago
Blocks: 928663
Comment on attachment 818145 [details] [diff] [review]
searchEngineRow_rtl.patch

Sorry Niv, this seems to have fallen through the cracks. In the future you should make sure to request review from an actual person, so someone is responsible. You can find suggested reviewers when you upload an attachment by clicking the 'suggested reviewers' link.
Attachment #818145 - Flags: review? → review?(mark.finkle)
Comment on attachment 818145 [details] [diff] [review]
searchEngineRow_rtl.patch

Given the time since the patch was prepared, I am unsetting r? for now and will get this bug on the list of RTL bugs that need to be unbitrotted.

The patch itself looks simple and straightforward, but we need to get all the RTL code moving toward landing again.
Attachment #818145 - Flags: review?(mark.finkle)
Priority: -- → P2

Comment 4

8 months ago
See bug 935388 comment 8 - these bugs are apparent also here in latest Nightly builds..

Plus, for some reason I can't see search suggestions from Google. It's simply blank. Are others experiencing the same issue?
Hi Max, 
would you mind checking these symptom ? 
Is it a RTL related issue ? Or we should file another big for this ?
Thank you very much.
Flags: needinfo?(max)

Comment 6

8 months ago
Created attachment 8816283 [details]
Missing search suggestions

Same here, I see a Google icon in the search suggestions but no results are shown next to it.

Updated

8 months ago
Depends on: 1321633

Updated

8 months ago
Hardware: x86 → Unspecified
Version: 27 Branch → unspecified
(Assignee)

Comment 7

8 months ago
Hi,

Is should be RTL related bug. I'll take it from here.
Assignee: nobody → max
Flags: needinfo?(max)
Comment hidden (mozreview-request)
Attachment #818145 - Attachment is obsolete: true
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true

Comment 9

7 months ago
mozreview-review
Comment on attachment 8818839 [details]
Bug 927667 - [RTL] Align suggestion to end of icon,

https://reviewboard.mozilla.org/r/98776/#review99376
Attachment #8818839 - Flags: review?(s.kaspari) → review+
(Assignee)

Updated

7 months ago
Keywords: checkin-needed

Comment 10

7 months ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/111b09bfa316
[RTL] Align suggestion to end of icon, r=sebastian
Keywords: checkin-needed

Comment 11

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/111b09bfa316
Status: ASSIGNED → RESOLVED
Last Resolved: 7 months ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
(Assignee)

Updated

7 months ago
Keywords: checkin-needed

Comment 12

7 months ago
I can confirm the latest Nightly builds fixes the search suggestions from Google issue, but this bug still depends on bug 1321633.
Reopening.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Keywords: checkin-needed

Comment 13

6 months ago
The suggestions work fine. 
The connected bug is fixed (partially as fading doesn't work on Arabic it seems but it is faded on RTL) 

Tested with AR Fennec 53.01 2017-01-17 with Pixel Android 7.1.1
Status: REOPENED → RESOLVED
Last Resolved: 7 months ago6 months ago
Resolution: --- → FIXED

Updated

6 months ago
Status: RESOLVED → VERIFIED

Updated

6 months ago
QA Contact: ioana.chiorean
Blocks: 1319302
You need to log in before you can comment on or make changes to this bug.