927689 - [traceback] BadStatusCodeError: 500 with ?product=Firefox&page=-1

Status: VERIFIED FIXED

(Socorro Graveyard :: Middleware, defect, P2)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

https://crash-stats.allizom.org/search/?product=Firefox&page=-1 throws:

BadStatusCodeError: 500: on: http://socorro-mware-stage-zlb.webapp.phx1.mozilla.com/bpapi/supersearch/product/Firefox/_results_offset/-100/_results_number/50/_facets/signature/

Stacktrace (most recent call last):

  File "django/core/handlers/base.py", line 111, in get_response
    response = callback(request, *callback_args, **callback_kwargs)
  File "waffle/decorators.py", line 36, in _wrapped_view
    return view(request, *args, **kwargs)
  File "crashstats/supersearch/views.py", line 176, in search_results
    search_results = api.get(**params)
  File "crashstats/crashstats/models.py", line 302, in get
    expect_json=expect_json)
  File "crashstats/crashstats/models.py", line 179, in fetch
    raise BadStatusCodeError('%s: on: %s' % (resp.status_code, url))

Errormill: https://errormill.mozilla.org/webtools/socorro-stage/group/111710/

Comment 1

[[DEACTIVATED] Adrian Gaudebert]

Pull request: https://github.com/mozilla/socorro/pull/1612

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/7cf4b111a82aaa7e373c0ac9653e8175b11aa326
Fixes bug 927689 - Sanitized page parameter to avoid it being negative. r=peterbe

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on staging:

https://crash-stats.allizom.org/search/?product=Firefox&page=-1

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on prod, too: https://crash-stats.mozilla.com/search/?product=Firefox&page=-1