Closed Bug 927716 Opened 11 years ago Closed 6 years ago

B2G SMS & MMS: sending functions need to eat parameters for requesting delivery report

Categories

(Firefox OS Graveyard :: RIL, defect)

Other
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-b2g:-)

RESOLVED WONTFIX
blocking-b2g -

People

(Reporter: airpingu, Unassigned)

References

Details

+++ This bug was initially created as a clone of Bug #919977 +++

Please see the user story at bug 919977. The AC 3 says:

  "AC 3: As a user I want to the per message basis configuration to override the default configuration."

To do this, the messaging APIs for sending SMS/MMS need to eat parameters for requesting delivery report per message basis. The proposed API changes will be:

partial interface nsIDOMMozMobileMessageManager
{
  jsval send(in jsval number, in DOMString message, boolean requestDeliveryReport);

  nsIDOMDOMRequest sendMMS(in jsval parameters, boolean requestDeliveryReport);
}
Maybe you can add this boolean in the parameters object instead for sendMMS ?

(same for in bug 927718)

For send, maybe it's a good time to use a parameters object too ?
(In reply to Julien Wajsberg [:julienw] from comment #1)
> Maybe you can add this boolean in the parameters object instead for sendMMS ?

IMO, what MmsParameters contains is more like content but requestDeliveryReport is more like a setting to specify how to send the content. It sounds better to me to think of requestDeliveryReport as an API parameter.

dictionary MmsParameters {
  sequence<DOMString> receivers;
  DOMString? subject = null;
  DOMString? smil = null;
  sequence<MmsAttachment> attachments;
};

dictionary MmsAttachment
{
  DOMString? id;
  DOMString? location;
  nsIDOMBlob content;
};

W3C also thinks of the sending function in a similar way to deal with MMS content and service ID [1].

> 
> For send, maybe it's a good time to use a parameters object too ?

W3C still treats them separately for sending SMS [2]. Maybe it's fine for now.


[1] http://messaging.sysapps.org/#mmsmanager-interface
[2] http://messaging.sysapps.org/#smsmanager-interface
That's because I dislike functions with lots of parameters, especially booleans...

How about one string parameter "report" then, that could have 4 different values:
* null
* "delivery"
* "read"
* "delivery-read"

Another idea: an array parameter, that could contains 2 delivery string values: "read" and "delivery" or be null.
Sounds like another nice alternative! Could you please put your comments to the WebAPI mailing list (title: Change Messaging API to Manage MMS Read Report for V1.3)? That would be nice if we could get W3C synchronized at the same time.
Please see bug 919977, comment #8 and bug 919977, comment #9. We don't hurry to support this for V1.3 but eventually we will.
blocking-b2g: 1.3? → ---
Severity: blocker → normal
blocking a committed 1.3 user story. 1.3+
blocking-b2g: --- → 1.3+
revert the blocking flag per comment 5
blocking-b2g: 1.3+ → ---
Keywords: dev-doc-needed
Gene, I just set target milestone to 2/28.
Because this is blocking bug 919977 which is must-have before end of Feb.
Flags: needinfo?(gene.lian)
Target Milestone: --- → 1.4 S2 (28feb)
That said, maybe it will be unprioritized because of the recent scheduling change.
Hi Wesley,

I'd like to pass this to Bevis since I already switched to the stream-3 team.

Hi Bevis,

I already had a road map in my mind. Please feel free to discuss with me if you face any difficulties. Thank you!
Assignee: gene.lian → btseng
Flags: needinfo?(gene.lian)
blocking-b2g: --- → 1.4?
blocking-b2g: 1.4? → ---
Component: Gaia::SMS → RIL
Hi Wesley,

Please help to confirm if this is still a blocker to 1.4 S2 (28feb).

Thanks
Flags: needinfo?(whuang)
Flags: needinfo?(whuang)
Target Milestone: 1.4 S2 (28feb) → ---
Put this bug into backlog.
blocking-b2g: --- → backlog
blocking-b2g: backlog → -
Blocks: b2g-sms, b2g-mms
No longer depends on: b2g-sms, b2g-mms
no longer following up this bug.
Assignee: btseng → nobody
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.