927735 - The URL constructor and the URL.href setter shouldn't throw XPathException

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Masatoshi Kimura [:emk]]

They should use aRv.ThrowTypeError().
If some C++ callers use URL::Constructor or URL::SetHref, they will have to call rv.ClearMessage() on failure. See nsContentUtils::ConvertStringFromCharset for an example.

Comment 1

[Andrea Marchesini [:baku]]

Attachment: exceptions2.patch

Comment 2

[Masatoshi Kimura [:emk]]

Comment on attachment 818245 [details] [diff] [review]
exceptions2.patch

>+    is(e.name, 'TypeError', "error: typeError");

|e instanceof TypeError| would be better to make sure that e is not a DOMException.

Comment 3

[Andrea Marchesini [:baku]]

Attachment: exceptions2.patch

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9475a3189256

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9475a3189256

Comment 6

[Boris Zbarsky [:bzbarsky]]

> They will have to call rv.ClearMessage() on failure.

That seems really annoying.  I filed bug 933378 to make this more safe.