927762 - Mutt test failure "List of add-ons has been correctly transferred." in tests/python/test_addons.py

Status: RESOLVED FIXED

(Testing Graveyard :: Mozmill, defect)

Description

[Andrei Eftimie]

Mutt python test: tests/python/test_addons.py fails with "List of add-ons has been correctly transferred."

At a quick glance looks like a problem with the persisted object.

(I would not be surprised if this is related to failing to encode and serialise as JSON some characters before saving them into the persisted object)

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

We need more information here! Please show us what you see in the command line.

Comment 2

[Andrei Eftimie]

Attachment: persisted.addons.txt

Comment 3

[Andrei Eftimie]

Attachment: results.appinfo.addons.txt

My initial assumption appears to be wrong.

There seems to be a genuine difference between persisted['addons'] and results.appinfo['addons']

Attached are both JSON encoded addons lists.
They are taken just before the assertion that fails here:
https://github.com/mozilla/mozmill/blob/master/mutt/mutt/tests/python/test_addons.py#L47

Comment 4

[Andrei Eftimie]

Erm I mistyped, there's no JSON there, they are python objects.

Comment 5

[Andrei Eftimie]

2 Addons have differences: Quicktime and Java

Both of them have exactly the same difference,
results.appinfo['addons'] has the following extra information: 
> u'foreignInstall': True,
> u'isPlatformCompatible': True,
> u'isCompatible': True,
> u'optionsType': 4,
> u'optionsURL': u'chrome://mozapps/content/extensions/pluginPrefs.xul',
> u'providesUpdatesSecurely': True,
> u'updateDate': u'2012-06-22T23:04:50.000Z',

I don't know where this comes from.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Please dump those objects correctly to the console so we get JSON output. Then please reformat at http://jsonviewer.stack.hu. Thanks.

Comment 7

[Andrei Eftimie]

Attachment: persisted.addons.txt

Comment 8

[Andrei Eftimie]

Attachment: results.appinfo.addons.txt

I can't link http://jsonviewer.stack.hu/ directly to these attachments as it doesn't work over https and bugzilla doesn't serve attachments over plain http :(

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

So you are saying that on the Python side there is more information available as on the JS side? Where have you added those dumps? This is somewhat impossible.

Does this only happen on OS X for you? Also which version of Firefox? Nothing of that has been mentioned yet.

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Ok, I can reproduce this bug. Looks like it is a regression from my fix on bug 918255. Strangely it was working at that time.

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Ups. That's really my fault. Not sure how this slipped through. :/ But the file testAddon.js under the python test folder hasn't gotten the same update.

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: 0001-Bug-927762-Mutt-test-failure-List-of-add-ons-has-bee.patch

So to not run into the same issue again, the mozmill.js module should export the getAddons() method. That way tests can re-use it and we don't retrieve different information and pass it back to the Python side.

Andrei, that fixes the test for me.

Comment 13

[Andrei Eftimie]

Comment on attachment 818631 [details] [diff] [review]
0001-Bug-927762-Mutt-test-failure-List-of-add-ons-has-bee.patch

Review of attachment 818631 [details] [diff] [review]:
-----------------------------------------------------------------

Works fine for me.

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Pushed as:
https://github.com/mozilla/mozmill/commit/9cebaf147e1c2a87d47ddfdbe9d4ea1d93b0a90e (master)
https://github.com/mozilla/mozmill/commit/4872477e75816c90d094d80d3ed3217b2932b4eb (hotfix-2.0)