927766 - Button "Join hidden network" is not localized during FTE

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Description

[Francesco Lodolo [:flod]]

Using Geeksphone with 1.2, button is displayed in English.

Button has an id but not a data-l10n-id
https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/ftu/index.html#L188

Comment 1

[Francesco Lodolo [:flod]]

I'm checking the original PR and there are other strings not marked with data-l10n-id
https://github.com/mozilla-b2g/gaia/pull/9828/files

<option>WEP</option>
<option selected>WPA-PSK</option>
<option>WPA-EAP</option>

Since we have similar strings in Settings, not sure why these are hard-coded
https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/locales/settings.en-US.properties#L301

Comment 2

[Axel Hecht [:Pike]]

Adding l12y keyword and requesting koi

Comment 3

[Francesco Lodolo [:flod]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12941

Pointer to Github pull-request

Comment 4

[Fernando Campo (:fcampo)]

Comment on attachment 819097 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12941

short and clear. Thanks Francesco.

wonder if we need also review from l10n team?

Comment 5

[Francesco Lodolo [:flod]]

Technically I'm part of the l10n team (Pike is already CCed anyway) ;-)
Maybe adding WEP, WPA, etc. is a bit overkill, but I think it could be needed for locales with non latin script.

P.S. Someone needs to merge this PR for me, since I have no commit rights over there.

Comment 6

[Fernando Campo (:fcampo)]

(In reply to Francesco Lodolo [:flod] from comment #5)
> Technically I'm part of the l10n team (Pike is already CCed anyway) ;-)
Oh, didn't know that, I only knew pike and stas :)

> Maybe adding WEP, WPA, etc. is a bit overkill, but I think it could be
> needed for locales with non latin script.
Agree

> P.S. Someone needs to merge this PR for me, since I have no commit rights
> over there.

merged on master https://github.com/mozilla-b2g/gaia/commit/114a899d6878f92170f471281a5d1de9bac55c48

Comment 7

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 114a899d6878f92170f471281a5d1de9bac55c48 to:
v1.2: 147207b1125c31e9dd63daae5365b2488ab70e45

Comment 8

[Tony Nguyen]

Verified on 1.2 build. 

Environmental Variables:
BuildID: 20131111004004
Gaia: 670b2c8329bca6f142939185be71274166d82bb8
Gecko: 1ac147e4e2f0
Version: 26.0