927823 - Enable or Disable a plugin in Addons Manager doesn't work if about:plugins is opened too on ESR17

Status: RESOLVED WORKSFORME

(Core Graveyard :: Plug-ins, defect, P2)

Description

[mario garbi]

We noticed this with our mozmill automated tests. Basically when we open Addons Manager and then about:plugins any change we make to the plugins in AM won't stick after a restart and aren't received by about:plugins. This also happens if we try to make multiple changes to the same addon without restarting the browser after each one as presented in the manual steps below.
This happens only with ESR17 on Linux 13.04.
http://mozmill-daily.blargon7.com/#/functional/report/f54ca65f73fd56845c30b7ab7d08923b


Manual steps to reproduce with a single change to plugin

1. Open an ESR17 build
2. Open Addons Manager (Ctrl Shift A)
3. Open "about:plugins"
4. Disable a plugin (we can reproduce it with any of them)
5. Refresh "about:plugins" page
6. Restart the browser
7. Open the Addon Manager

Expected results:
1. The plugin is gone from the list on about:plugins page
2. The plugin is shown as disabled in Addons Manager

Actual results:
1. "about:plugins" doesn't change and the plugin remains visible and enabled
2. After restarting the browser the addon is still enabled

---------------------------------------------------------------
Manual steps to reproduce with working order but two changes to plugin without restart

1. ESR17
2. Open about:plugins
3. Open AMO
4. Disable a plugin (we can reproduce it with any of them)
5. Refresh about:plugins page
6. Check that plugin dissapears from the list
7. Go to the Addon Manager tab (do not restart browser)
8. Re-enable plugin
9. Restart browser
10. Check about:plugins

Expected results:
1. The plugin is enabled in about:plugins 
2. The plugin is enabled in Addons Manager after restart

Actual results:
1. It works ok up to step 7 but step 8 doesn't work 
2. After restarting the browser the addon remains disabled as set at step 4

---------------------------------------------------------------
Manual steps to change a plugin that work with a single change:

1. Open an ESR17 build
2. Open "about:plugins"
3. Open Addons Manager (Ctrl Shift A)
4. Disable a plugin (we can reproduce it with any of them)
5. Refresh "about:plugins" page
6. Restart the browser
7. Open the Addon Manager

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This is not a security related bug for the ESR17 branch. So I don't see any chance of getting this fixed, even with EOL coming up soon. We simply should disable the test for esr17.

Comment 2

[Georg Fritzsche [:gfritzsche]]

Right, that matches my understanding. Can you take or assign this Henrik?

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Well, I cannot do anything for this bug, given that I'm not a module owner or driver. But I will make sure we get the test disabled on bug 927361.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Well, I think WONTFIX is the better solution then.

Comment 5

[Benjamin Smedberg]

This is fixed on trunk (don't know the bug# offhand), so WONTFIX doesn't make any sense. If it weren't fixed, we'd fix it!