Impprove test_import_contacts_from_SIM

RESOLVED FIXED

Status

Firefox OS
Gaia::UI Tests
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: AlinT, Assigned: AlinT)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
We are currently returning the Contacts app after tapping import_from_sim: https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/gaiatest/tests/functional/contacts/test_import_contacts_from_sim.py#L25
when we should actually go back in the Contacts app then assert that the contacts are there
(Assignee)

Updated

5 years ago
Assignee: nobody → alin.trif
(Assignee)

Comment 1

5 years ago
Created attachment 818895 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12931

Pointer to Github pull-request
(Assignee)

Updated

5 years ago
Attachment #818895 - Flags: review?(zcampbell)
Attachment #818895 - Flags: review?(moz.teodosia)
Attachment #818895 - Flags: review?(florin.strugariu)
Attachment #818895 - Flags: review?(bob.silverberg)
Attachment #818895 - Flags: review?(andrei.hutusoru)

Comment 2

5 years ago
Comment on attachment 818895 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12931

LGTM
Attachment #818895 - Flags: review?(andrei.hutusoru) → review+
Attachment #818895 - Flags: review?(florin.strugariu) → review+

Comment 3

5 years ago
Comment on attachment 818895 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12931

LGTM.
Attachment #818895 - Flags: review?(moz.teodosia) → review+

Comment 4

5 years ago
Comment on attachment 818895 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12931

r+ here too!
Attachment #818895 - Flags: review?(zcampbell)
Attachment #818895 - Flags: review?(bob.silverberg)
Attachment #818895 - Flags: review+

Comment 5

5 years ago
Merged
https://github.com/mozilla-b2g/gaia/commit/383089a06d8f33953b3f18fd80d577fc60b5971d
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.