927944 - Annotate crash reports with a list of DLLs that were blocked (windows)

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Benjamin Smedberg]

I'm somewhat worried that blocking some DLL loads may cause new crashes, for example the block in bug 812683. In order to gain confidence about deploying these kinds of blocks, I'd like to add an annotation which lists the DLLs that were blocked when a crash occurs.

Comment 1

[Benjamin Smedberg]

Attachment: bug927944-annotated-blocked

Comment 2

[(no longer active)]

Comment on attachment 819042 [details] [diff] [review]
bug927944-annotated-blocked

Review of attachment 819042 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/xre/nsWindowsDllBlocklist.cpp
@@ +22,5 @@
>  #include "nsWindowsHelpers.h"
>  
>  using namespace mozilla;
>  
> +#ifdef MOZ_CRASHREPORTER

Why did you remove this?  This will probably break SeaMonkey... <http://mxr.mozilla.org/comm-central/source/suite/app/Makefile.in#18>

@@ +283,4 @@
>  std::map<DWORD, const char*>* ReentrancySentinel::sThreadMap;
>  
> +/**
> + * This is a linked list of DLLs that have been blocked.

Please document why you're not using mozilla::LinkedList here (I agree that is the right choice!)

@@ +313,5 @@
> +
> +void
> +DllBlockSet::Add(const char* name, unsigned long long version)
> +{
> +  EnterCriticalSection(&sLock);

Any chance you could please move <http://mxr.mozilla.org/mozilla-central/source/xpcom/ds/TimeStamp_windows.cpp#192> to nsWindowsHelpers and use it here?  Implementing RAII manually is error prone.

@@ +332,5 @@
> +DllBlockSet::Write(HANDLE file)
> +{
> +  EnterCriticalSection(&sLock);
> +  DWORD nBytes;
> +  __try {

Please document why you're using __try/__except here.

Comment 3

[Benjamin Smedberg]

https://hg.mozilla.org/integration/fx-team/rev/d04bbdfff591
https://hg.mozilla.org/integration/fx-team/rev/e3d6e17ad7a3

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d04bbdfff591
https://hg.mozilla.org/mozilla-central/rev/e3d6e17ad7a3